Giter Site home page Giter Site logo

Comments (9)

mikepenz avatar mikepenz commented on May 29, 2024

@LethalMaus thank you for the report.

Can you reproduce this in the sample app? I just tried to see if the same happens in the FragmentActivity, and it doesn't appear to be the case.

I also notice the dialog has a different corner radius than the sample 🤔 Could it be a m2 vs m3 issue perhaps?

from aboutlibraries.

LethalMaus avatar LethalMaus commented on May 29, 2024

No worries, thanks for the great library. I haven't had the time to build a mini sample app. It could be that it's M2 as we have not yet migrated.

from aboutlibraries.

mikepenz avatar mikepenz commented on May 29, 2024

Appreciated @LethalMaus

You can use the sample app in this repo perhaps: https://github.com/mikepenz/AboutLibraries/tree/develop/app

Having it reproduced in this context would really help!

from aboutlibraries.

LethalMaus avatar LethalMaus commented on May 29, 2024

Alright, as soon as I get the chance I'll do so. The app is not compiling straight off the bat on my mac, will try it on my Windows PC later on this week and let you know.

from aboutlibraries.

mikepenz avatar mikepenz commented on May 29, 2024

I am building this project on a Mac, any details on what is not compiling for you?

from aboutlibraries.

LethalMaus avatar LethalMaus commented on May 29, 2024
A problem occurred configuring root project 'AboutLibraries'.
> Could not determine the dependencies of task ':plugin-build:plugin:compileKotlin'.
   > No matching toolchains found for requested specification: {languageVersion=11, vendor=any, implementation=vendor-specific} for MAC_OS on aarch64.
      > No locally installed toolchains match and toolchain download repositories have not been configured.

I didnt spend long looking into it. I presume its because I'm on Java 17

from aboutlibraries.

mikepenz avatar mikepenz commented on May 29, 2024

Ah yes. It's searching for a java 11 on your system. And can't find any

from aboutlibraries.

LethalMaus avatar LethalMaus commented on May 29, 2024

Found the issue. Layout gravity is the cause of the issue, so nothing to do on your side

<style name="Theme.Custom.Dialog" parent="Theme.MaterialComponents.DayNight.Dialog.Alert.Bridge">
        <item name="colorAccent">@color/app_color</item>
        <item name="android:layout_gravity">bottom</item> <!-- removing this line resolves the issue -->
        <item name="android:windowBackground">@drawable/dialog_background</item>
        <item name="android:windowMinWidthMinor">80%</item>
    </style>

from aboutlibraries.

mikepenz avatar mikepenz commented on May 29, 2024

Thank you for reporting back! greatly appreciated 👍

from aboutlibraries.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.