Giter Site home page Giter Site logo

Comments (5)

Yakutoc avatar Yakutoc commented on June 7, 2024 1

Thanks for your answers and help.

I decided to do it differently.

I'll just cut out everything that comes after "### What/why сhanged"

"custom_placeholders": [  
  {  
    "name": "DESC",  
    "source": "BODY",  
    "transformer": {  
        "pattern": "(?:\n### What\/why сhanged)(.*)",  
        "flags": "s",  
        "target": " "  
    }  
  }  
]

from release-changelog-builder-action.

mikepenz avatar mikepenz commented on June 7, 2024

The custom_placeholders use javascripts replace method.

As far as I can observe, I suppose you would expect it to use match instead?
(debugger preview with match in use, which would do what you expect)

Screenshot 2023-11-30 at 15 09 11

from release-changelog-builder-action.

Yakutoc avatar Yakutoc commented on June 7, 2024

you would expect it to use match instead

Yep =)

I expected that 1$ is the result of a regular expression and that it will replace its BODY.

Is it even possible to do this?

from release-changelog-builder-action.

mikepenz avatar mikepenz commented on June 7, 2024

Unfortunately the replace function of JavaScript works differently

You can best test its behavior here for example: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace

const paragraph = "## Release Notes\n\n### Dropdown\n\nsome text\n\n### What/why Changed\n\nsome text\n\nsome text";

const regex = /(?:## Release Notes)(.*)(?:### What\/why Changed)/s;

// this is the behaviour within the action
console.log("FIRST EXAMPLE");
console.log(paragraph.replace(regex, '$1'));

// this would be the result of match (which returns an array, and has no target)
console.log("SECOND EXAMPLE");
console.log(paragraph.match(regex));

// the index 1 result of the match array
console.log("THRID EXAMPLE");
console.log(paragraph.match(regex)[1]);

from release-changelog-builder-action.

mikepenz avatar mikepenz commented on June 7, 2024

I would love to find a better solution with javascript which would work like match, and has the support for the "target" - as that would most of the times be the most convenient way of doing things.

from release-changelog-builder-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.