Giter Site home page Giter Site logo

Comments (9)

mikepenz avatar mikepenz commented on June 14, 2024 1

if you specify the tag it has to exist as tag. If the tag does not exist, you can pass in the git ref (commit sha) instead of the state you want to compare with.

The action fails as it tries to get the state from the toTag you pass, which does not exist.

from release-changelog-builder-action.

mikepenz avatar mikepenz commented on June 14, 2024 1

@cYKatherine awesome news! glad I was able to help.

from release-changelog-builder-action.

mikepenz avatar mikepenz commented on June 14, 2024

Good day.

The action likely has no access to those tags. Which token do you provide for it to run?
Please also provide how you configure the action in your CI yaml file?

from release-changelog-builder-action.

cYKatherine avatar cYKatherine commented on June 14, 2024

Hello @mikepenz , thank you so much for the quick response!

      name: Build Docker Changelog
      id: github_release_docker
      if: ${{ inputs.is_release == 'true' && inputs.publish_platform == 'Docker'}}
      uses: mikepenz/release-changelog-builder-action@v4
      with:
        toTag: v${{ inputs.version_number_input }}
        configurationJson: |
          {
            "template": "#{{CHANGELOG}}\n## Installation\n```\ndocker pull ${{ inputs.tags }}\n```\n\n## Image reference to deploy: \n```\n${{ inputs.image_tag }}\n```\n\n## Changelog\n#{{UNCATEGORIZED}}",
            "pr_template": " - #{{TITLE}} - ( PR: ##{{NUMBER}} )"
          }
      env:
        GITHUB_TOKEN: ${{ inputs.github_token }}

Above is my yaml file. I passed in the github_token through inputs as there are several layers of call to pass this through. The github_token value should be legit as I am able to do actions like docker/login-action@v3 using this value.

from release-changelog-builder-action.

mikepenz avatar mikepenz commented on June 14, 2024

Thank you.

Yes that should in general work.

The error is thrown by the code here:

failOrError(`💥 Failed to retrieve - Invalid tag? - Because of: ${error}`, failOnError)

And is usually giving Not found if the request does not succeed for the token:
let commits: RestEndpointMethodTypes['repos']['compareCommits']['response']['data']['commits'] = []

the tags are on this repo you execute for? And the token should have read access to pull requests and commits?

In case, please validate the permissions are granted: https://github.com/mikepenz/release-changelog-builder-action?tab=readme-ov-file#token-permission

from release-changelog-builder-action.

cYKatherine avatar cYKatherine commented on June 14, 2024

In my action I have write permission to everything, that should imply read permission as well right?

    runs-on: ubuntu-latest
    permissions:
      contents: write
      security-events: write
      packages: write
      pull-requests: write

The tags are indeed on the repo I execute for:
image

Not really sure what else I'm missing 🤔

from release-changelog-builder-action.

mikepenz avatar mikepenz commented on June 14, 2024

Oh I maybe see it.

The action tries to get the diff for 0.10.10 to 0.10.16
Screenshot 2024-01-30 at 19 15 26

However your screenshot shows a 0.10.4 and a 0.10.10 but no 0.10.16

from release-changelog-builder-action.

cYKatherine avatar cYKatherine commented on June 14, 2024

The v0.10.16 is the latest tag we are releasing to: toTag: v${{ inputs.version_number_input }}, I don't think we need to have that to see the changelog?

from release-changelog-builder-action.

cYKatherine avatar cYKatherine commented on June 14, 2024
image You are absolutely right! It works now!! Thank you so much for your help 👍

from release-changelog-builder-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.