Giter Site home page Giter Site logo

Comments (9)

Aetherinox avatar Aetherinox commented on June 1, 2024 1

Oops, sorry. I thought I replied back, but somewhere along the line, my brain died.

Yes, thank you, it worked perfectly. I can now add descriptions again to my commits.

Been using the fix for the last two weeks and not a single issue. I've got this github action running on like 7 of my repos without any issues.

from release-changelog-builder-action.

Aetherinox avatar Aetherinox commented on June 1, 2024

Update, because I had to push some changes today, and it happened more, but this time with 3-4 items.

I noticed that it's occurring with commits that I've added additional notes to (I have commitMode enabled.)

If I push a commit with just a title, it shows in the list fine. However, if I throw in additional comments in the commit description; it doesn't show in the changelog on the releases page.

image

image

image


Second example:

image

image

image


The same is true for 2 other commits I made. They were skipped and had descriptions.

The other interesting note is that in the logs, it seems to think they are uncategorized, even though they follow the exact same commit standards that the working ones did.

  ℹī¸ Removed 0 pull requests during deduplication
  ℹī¸ Used 0 transformers to adjust message
  ✒ī¸ Wrote messages for 11 pull requests
  ℹī¸ Ordered all pull requests into 13 categories
  ✒ī¸ Wrote 7 categorized pull requests down
  ✒ī¸ Wrote 4 non categorized pull requests down
  ✒ī¸ Wrote 0 ignored pull requests down
  ℹī¸ Filled template

from release-changelog-builder-action.

mikepenz avatar mikepenz commented on June 1, 2024

That's a tricky one. it could be that the regex does not match if it is multi-line. what regex flags are you setting?

from release-changelog-builder-action.

mikepenz avatar mikepenz commented on June 1, 2024

Oh actually we only take the first line 🤔

Screenshot 2024-04-10 at 14 04 11

from release-changelog-builder-action.

Aetherinox avatar Aetherinox commented on June 1, 2024

Actually good question, are you referring to category.rules.flags? Because from what I see, I have not set these yet.

from release-changelog-builder-action.

mikepenz avatar mikepenz commented on June 1, 2024

In hindsight given we trim it to only keep the first line for the summary it shouldn't matter 🤔
unless we use the message for the title. 🤔

Edit: we use the summary: https://github.com/mikepenz/release-changelog-builder-action/blob/develop/src/pr-collector/commits.ts#L113

So I am not sure yet.

Can you point me to the CI run so I might test it locally?

from release-changelog-builder-action.

Aetherinox avatar Aetherinox commented on June 1, 2024

Keep in mind, my workflow has a lot of steps, so you may want to cut them down.
Workflow: https://github.com/Aetherinox/obsidian-gistr/blob/main/.github/workflows/release-npm.yml

The particular action is: https://github.com/Aetherinox/obsidian-gistr/actions/runs/8544149198/job/23409544035, which produced this release with the messed up changelog: https://github.com/Aetherinox/obsidian-gistr/releases/tag/1.6.5

For the workflow, check the step "📝 Changelog â€ē Build (Categorized)", there's a step below labeled Uncategorized, which is not being used right now. The step you want can be directly accessed via https://github.com/Aetherinox/obsidian-gistr/blob/a9e515f7799385cbe4b51ba9d31f8c8a1b42828f/.github/workflows/release-npm.yml#L264

from release-changelog-builder-action.

mikepenz avatar mikepenz commented on June 1, 2024
Screenshot 2024-04-11 at 15 20 35

So debugging this. message and title appear to look fine.

Looking further though, shows that given you don't specify which property to extract the label from (using the label extractor) it will automatically pick the body
Screenshot 2024-04-11 at 15 24 13

Given the body is multiple lines, the standard regex won't match now. regexes handle multi line different. I believe the m flag would change the behavior for multi line.

Anyways, the easiest solution in your case is to adjust the config to not match the lable on the body, but instead of the single line title:

E.g. change the label_extractor to:

"label_extractor": [
    {
        "pattern": "^(build|ci|change|chore|doc|docs|wiki|remove|deprecate|security|dependency|dep|package|feat|feature|fix|bug|perf|optimize|optimization|refactor|style|test|tests|vault):(.*)",
        "target": "$1",
        "on_property": "title"
    },
    {
        "pattern": "^(build|ci|change|chore|doc|docs|wiki|remove|deprecate|security|dependency|dep|package|feat|feature|fix|bug|perf|optimize|optimization|refactor|style|test|tests|vault){1}(\\([\\w\\-\\.]+\\))?(!)?:(.*)",
        "target": "$1",
        "on_property": "title"
    }
],

from release-changelog-builder-action.

mikepenz avatar mikepenz commented on June 1, 2024

Please let me know if that fixed it. closing due to inactivity

from release-changelog-builder-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤ī¸ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.