mikeqfu/pyrcs

PyRCS: an open-source tool for collecting railway codes used in different UK rail industry systems

pyrcs's Issues

Missing files in sdist

It appears that the manifest is missing at least one file necessary to build
from the sdist for version 0.2.6. You're in good company, about 5% of other
projects updated in the last year are also missing files.

+ /tmp/venv/bin/pip3 wheel --no-binary pyrcs -w /tmp/ext pyrcs==0.2.6
Looking in indexes: http://10.10.0.139:9191/root/pypi/+simple/
Collecting pyrcs==0.2.6
  Downloading http://10.10.0.139:9191/root/pypi/%2Bf/fad/d9423f9b11cdd/pyrcs-0.2.6.tar.gz (41 kB)
    ERROR: Command errored out with exit status 1:
     command: /tmp/venv/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-wheel-5d39cnf_/pyrcs/setup.py'"'"'; __file__='"'"'/tmp/pip-wheel-5d39cnf_/pyrcs/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-wheel-5d39cnf_/pyrcs/pip-egg-info
         cwd: /tmp/pip-wheel-5d39cnf_/pyrcs/
    Complete output (5 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-wheel-5d39cnf_/pyrcs/setup.py", line 22, in <module>
        with open('requirements.txt') as f:
    FileNotFoundError: [Errno 2] No such file or directory: 'requirements.txt'
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

Including PyLint

We're trying to add Pylint to the project so the code can be checked on each Pull request.

`FutureWarning` for `inplace` operation

Related class/method:

• Stations.collect_locations_by_initial()

When setting update=True, the method can be successfully executed, but the following warning message appears:

... \pyrcs\other_assets\station.py:526: FutureWarning: A value is trying to be set on a copy of a DataFrame or Series through chained assignment using an inplace method.
The behavior will change in pandas 3.0. This inplace method will never work because the intermediate object on which we are setting values always behaves as a copy.
For example, when doing 'df[col].method(value, inplace=True)', try using 'df.method({col: value}, inplace=True)' or df[col] = df[col].method(value) instead, to perform the operation inplace on the original object.

dat['Station'].replace(errata_, regex=True, inplace=True)

This may suggest that the current approach will not work in pandas 3.0 and provides alternative methods to perform the operation in place on the original object.

Locations of signal boxes

Hi, this looks like a great resource. Just wondering if there is any way to derive the geographical location in latitude and longitude (ie not just ELR) of the UK signal boxes. Thanks.