mikescamell/shared-element-transitions

Source code for a blog post series on Shared Element Transitions in Android

shared-element-transitions's Issues

New Fragment added on top of previous one each time the activity is recreated

In RecyclerViewToFragmentActivity you add the fragment but you don't test if savedInstanceState is null first.

When re-creating the Activity, a new fragment will be added on top of the previous one because you used add() and not replace().
It's recommended to add it once, when savedInstanceState is null.

Method Missing

I had just downloaded the code and try to run getting this method missing
postponeEnterTransition();
This method is missing please help

postponeEnterTransition() does not work in "Picasso Fragment to Fragment" sample.

Calling of a method postponeEnterTransition() has no effect. To check it remove startPostponedEnterTransition() calls in a Picasso callback. A transition will be still plays, but it should not. Documentation says: "Likewise, postponement only works if FragmentTransaction optimizations are enabled." So, to fix the sample call setAllowOptimization(true) of a FragmentTransaction.

Flash fix does not works on Android 7.0

Flash fix does not works on Android 7.0. A toolbar blinks even more then without a fix.

How to add more transition names

How can i add more transition names to recyclerview click listener

resize when back

please see the picture with starfish example

when I press back button the animation get back but a rare size shrink occurs. (in the second back press in gif you will see clearly)

Do you have any ideas of what is going on?

Thanks

blinking and flashing in fragment navigation component

so in fragment by navigation component i get flashing and blinking, how to resolve that?

Unnecessarily complexity in RecyclerView sample

I noticed several inaccuracies within your RecyclerView blog post which are reflected in this sample's code.

1. AnimalDetailActivity TransitionName
   Transition names on the views don't have to be the same on both ends of the transition. They have to be unique for their own view hierarchy though and be matched within makeSceneTransitionAnimation. See this for an example.
2. In RecyclerViewActivity: The ActivityOptionsCompat call can be simplified by applying the suggestion of 1.
3. The AnimalItemClickListener's parameter transitionName can be removed when following through with the suggestions so far.
4. You're removing the transition in the ViewPagerFragment on the way back to the RecyclerView.
   There is a better way: When using onActivityReenter you can postpone a transition and remap views.

These suggestions can also be applied within the recycler_view_to_fragment example.

Source: I wrote this.

Simplifications for SimpleActivity sample

In your SimpleActivity example you're setting matching transition names in different (A / B and strings.xml) ways.
Instead of doing this you can pass in imageView.getTransitionName() into the last param the of ActivityOptionsCompat call.

This simplification can be made in several examples.

Fragment to Activity Transiction

I want to transit fragment to activity. I am using this

Intent intent = new Intent(getActivity(), SingleImage.class);
    intent.putExtra("item", songItem.getUrlC());
    intent.putExtra("view", ViewCompat.getTransitionName(imageView));

    ActivityOptionsCompat options = ActivityOptionsCompat.makeSceneTransitionAnimation(
            getActivity(),
            imageView,
            ViewCompat.getTransitionName(imageView));

    startActivity(intent, options.toBundle());

I can see a error in log cat

   java.lang.IllegalArgumentException: Shared element name must not be null

How i can solve it?? or can you give me any way??

Gorilla is under a text in "Fragment to fragment" sample.

ImageView with a gorilla is placed under a TextView during a transition. How can I place it in front of the text?

Return transition doesn't work

I have nested fragments inside a fragment and it works perfect when I enter the second fragment. But when I pop back stack to return to the first fragment it just normally returns without any animation or move or anything, like no shared elements ever defined. Also I'm using cardview for my recycler items layout.

android ActivityOptions.isReturning() NullPointerException

https://stackoverflow.com/questions/50199130/android-activityoptions-isreturning-nullpointerexception-shared-element-transi?noredirect=1#comment87415415_50199130