Giter Site home page Giter Site logo

Comments (6)

MikeSiLVO avatar MikeSiLVO commented on September 19, 2024

The problem I have with this is false positives. Filename additions could say anything and be completely inaccurate. Probing the file for information is not.

There a few examples of movies but off the top of my head Jaws 3 is usually referred to as Jaws 3D in this case it would wrongly be classified as 3-D when not.

I am not sure of a middle ground here since most users of the skin either rip content to HDD in a container like mkv or stream it...

from skin.aeon.nox.silvo.

Philmo67 avatar Philmo67 commented on September 19, 2024

Maybe a solution without false positives could be to test "3d" and its mode : sbs, tab or mvc ?
See https://kodi.wiki/view/3D

from skin.aeon.nox.silvo.

MikeSiLVO avatar MikeSiLVO commented on September 19, 2024

Doesn't using Kodi naming convention solve your issue?

If you name it that way then Kodi should mark it as stereoscopic, no?

from skin.aeon.nox.silvo.

Philmo67 avatar Philmo67 commented on September 19, 2024

That is exactly what I did and without the "String.Contains(ListItem.Filename..." clauses I added, no 3D flag can be displayed for a filestub. Filestubs are empty so kodi cannot flag it as stereoscopic, filename does not seem to be involved.
Actually, only the "isstereoscopic" flag is tested, not the filename in order to display the bluray3d.png logo

So maybe filename should be tested against :
3d.mvc
3d.sbs
3d.hsbs
3d.fsbs
3d.tab
3d.htab
3d.ftab
3d-mvc
3d-sbs
3d-hsbs
3d-fsbs
3d-tab
3d-htab
3d-ftab
3d_mvc
3d_sbs
3d_hsbs
3d_fsbs
3d_tab
3d_htab
3d_ftab
in order to avoid false positives ?

from skin.aeon.nox.silvo.

Philmo67 avatar Philmo67 commented on September 19, 2024

Actualy KODI wiki states :

Kodi uses regular expressions to check for certain flags in the filename.

In order to properly detect the stereomode, two tags need to be present in the filename. First, a '3D' tag has to be present that matches the following regex: [-. _]3d[-. _]

In addition to this, either a 'SBS' tag [-. _]h?sbs[-. _] or a 'TAB' flag [-. _]h?tab[-. _] must be present in the filename.

To trigger 3D flag, some skins seem to use :
<visible>ListItem.IsStereoscopic | String.Contains(ListItem.FilenameAndPath,.3d.) | String.Contains(ListItem.FilenameAndPath,hsbs) | String.Contains(ListItem.FilenameAndPath,sbs) | String.Contains(ListItem.FilenameAndPath,half-sbs)</visible>

from skin.aeon.nox.silvo.

MikeSiLVO avatar MikeSiLVO commented on September 19, 2024

What about trying what this person did?
Also HERE

https://kodi.wiki/view/NFO_files/Combination

from skin.aeon.nox.silvo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.