Giter Site home page Giter Site logo

Comments (5)

mikke89 avatar mikke89 commented on August 29, 2024 1

Okay, I guess I'm fine with the approach, at least until I see any real-world problems with it :)

from rmlui.

viciious avatar viciious commented on August 29, 2024

In this particular case, a button click event hides the document which triggers another event, in which a listener de-attaches itself right in the ProcessEvent call and that confuses the iterator.

from rmlui.

viciious avatar viciious commented on August 29, 2024

Changing the loop to read:

	for (auto it = begin, next = end; it != end; it = next)
	{
		next = std::next(it, 1);
		it->listener->ProcessEvent(event);
	}

fixes the assertion failure :)

from rmlui.

mikke89 avatar mikke89 commented on August 29, 2024

Yeah, I think the problem is that when adding or removing listeners, the iterators will be invalidated. Could you test the changes I committed?
The commit should help avoid invalidated iterators, but may result in a skip or repeat of a listener invocation.

from rmlui.

viciious avatar viciious commented on August 29, 2024

I think the best solution here would be to copy the slice of the original array to a temporary array and iterate over that.

from rmlui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.