milanistadev/nippochanswiftui

日報ちゃんのSwiftUI版=>Renewal 勤怠ちゃん

勤怠ちゃん 〜Kintai-chan〜

Overview of this app

This app is a Watch app using SwiftUI.
You can post fixed words on Slack using Apple Watch.

Commentary article

This app is a sample app made for Qiita Advent Calendar 2019.
The commentary is as follows. Written in Japanese.

https://qiita.com/MilanistaDev/items/dbc4d2c2cc4522f12972

Support

• macOS Catalina 10.15.1 and later
• Xcode 11.2.1 and later
• watchOS 6.1.1 and later

You need an iOS 13 or higher iPad or iPhone paired with your Apple Watch to input the information needed to post Slack.

How to use

1. Clone or download this project and build.
2. Edit or Delete preset data.

3. Open the Settings List Screen.

4. Input your activity and favorite emoji.

5. Input info for slack post

On this screen, enter the information required when posting Slack and use it as a parameter when sending. Similarly, text input is performed on the iOS 13 iOS device that is paired. Enter Slack's Webhook URL and GitHub account name, User name and favorite color code. This information will be used when posting to Slack. When the "?" Button is tapped, an explanation screen is displayed for each item in a modal manner.

Slack Webhook URL can be obtained from the following link.
Set the icon and user name for Slack posting in this site.

https://slack.com/services/new/incoming-webhook

※ New Entry was moved to bottom of ActivityList(v1.1.0~)

6. Slack post

Finally, you can post Slack by tapping the cell on the top list screen.

Existing bugs and issues

Bugs

Please inform when you find bugs.

issues

• When entering the Webhook URL, you cannot copy and paste on the iPhone side, so you must enter each character.
• Code is bad...

App update history

App Version	Date	MEMO
1.0.0	2019-12-20	v1.0.0 released.
1.1.0	2021-05-06	Bug fixed. Code Refactoring.

Contact

Please feel free to contact us if you find a bug or have any feedback.
Suggestions for adding functions and code corrections are also welcome.

let name = "Takuya Aso" 
let email = "milanista224" + "@" + "icloud.com"
let profession = "iOS Engineer"
let location = "Tokyo"

nippochanswiftui's Issues

ActivityList のコード改善

内容

• ActivityModel に ActivityType みたいな enum を導入

enum ActivityType: Int, Codable {
    case normal
    case setting
    case newEntry
}

• name で比較する代わりに @ViewBuilder を使って ActivityType で場合分けし，セルの View を返すようにする
• 子 View のプロパティ宣言が冗長な気がする

ActivityList の管理は EnvironmentObject でいいのではないか

ActivityList の管理は EnvironmentObject でいいのではないか。
List の操作があった際に更新できるように
ObservedObject をラップしたViewModelを子ビューに渡していってるが
EnvironmentObject を使う方が自然になる気がする。

PostActivity で @Published を付与するのは isShowDialog だけで十分

内容

• PostActivity で @published を付与するのは isShowDialog だけで十分

titleとmessageをstructなどでまとめてもよさそう。