milkru/vulkanizer

Advanced Vulkan rendering engine prototype

vulkanizer's Issues

Linux compilation and VMA issue

Hi, in linux I just get this easy fix issue:

vulkanizer/src/core/buffer.cpp: In function ‘Buffer createBuffer(Device&, BufferDesc)’:
vulkanizer/src/core/buffer.cpp:44:25: error: ‘memcpy’ was not declared in this scope
   44 |                         memcpy(buffer.pMappedData, _desc.pContents, buffer.byteSize);
      |                         ^~~~~~
vulkanizer/src/core/buffer.cpp:3:1: note: ‘memcpy’ is defined in header ‘<cstring>’; did you forget to ‘#include <cstring>’?
    2 | #include "buffer.h"
  +++ |+#include <cstring>
    3 |
make[3]: *** [CMakeFiles/vulkanizer.dir/build.make:109: CMakeFiles/vulkanizer.dir/src/core/buffer.cpp.o] Error 1

After adding the include all is fine. But I get this error from vma

$ ./build/vulkanizer 3rdparty/meshoptimizer/demo/pirate.obj

vulkanizer: vulkanizer/3rdparty/VulkanMemoryAllocator/src/../include/vk_mem_alloc.h:2780: void* vma_aligned_alloc(size_t, size_t): Assertion `0 && "Could not implement aligned_alloc automatically. Please enable C++17 or later in your compiler or provide custom implementation of macro VMA_SYSTEM_ALIGNED_MALLOC (and VMA_SYSTEM_ALIGNED_FREE if needed) using the API of your system."' failed. Aborted (core dumped)

any hint about it ?

not inssue, but fix mb?

Hi.
In func "getAspectMask" in "texture.cpp"
"return _format == VK_FORMAT_D32_SFLOAT ? VK_IMAGE_ASPECT_DEPTH_BIT : VK_IMAGE_ASPECT_COLOR_BIT;"
but this func also used in "createHzbTexture" which used VK_FORMAT_R16_SFLOAT, so mb
"return _format == VK_FORMAT_D32_SFLOAT || VK_FORMAT_R16_SFLOAT ? VK_IMAGE_ASPECT_DEPTH_BIT : VK_IMAGE_ASPECT_COLOR_BIT;" be better?

Please support MSYS2 MINGW64