min-ops/cruddy

A simple CRUD wrapper around Amazon DynamoDB

cruddy's Issues

README takes about query

The operation is now called search

How can I do a consistent read?

In boto3, I can do a consistent read with the following

table.get_item(
    Key={
        'id': self._my_id
    },
    ConsistentRead=True
)

Given the current _get() function, I am not sure how I could do that, resulting in all reads being eventually consistent.

Generate empty item JSON

It would be nice to have a CLI command that would generate a JSON object with the required attribute already present. That would allow me to then edit the file and give it to create.

Kinda like the CLI skeleton from the AWS CLI.

Get of id that doesn't exist raises KeyError

Not the best experience:

line 49, in load_xyz response = self._xyz_crud.get(self.id) 
File "/var/task/cruddy/__init__.py", 
line 210, in get item = response.raw_response['Item'] KeyError: 'Item'

I think returning a response would be better

LambdaClient is missing update

It looks like the LambdaClient is missing the update method...doh!

Must create before increment_counter. Discuss

Currently, if you call increment_counter on an id that doesn't existing in the table yet, the response is:

{
  "status": "error",
  "error_message": "The provided expression refers to an attribute that does not exist in the item",
  "error_code": "ValidationException",
  "error_type": null,
  "raw_response": null,
  "data": null,
  "metadata": null
}

That means you must first call create and give the item a starting number before you can subsequently call increment_counter.

I am thinking it would be nice to handle that inside cruddy. When the above happens, make a subsequent call to create and set the counter_name to whatever the increment is as the initial number.

Thoughts?

Fail gracefully when the Lambda func doesn't have the right permissions

I just did a

./cruddy search my_id=72538

and received the following stacktrace:

error
Traceback (most recent call last):
  File "/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/Current/bin/cruddy", line 9, in <module>
    load_entry_point('cruddy==0.9.0', 'console_scripts', 'cruddy')()
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 716, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 696, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 1060, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 889, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/click/decorators.py", line 64, in new_func
    return ctx.invoke(f, obj, *args[1:], **kwargs)
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/cruddy/scripts/cli.py", line 159, in search
    handler.invoke(data)
  File "/usr/local/lib/python2.7/site-packages/cruddy/scripts/cli.py", line 70, in invoke
    self._invoke_lambda(payload)
  File "/usr/local/lib/python2.7/site-packages/cruddy/scripts/cli.py", line 56, in _invoke_lambda
    click.echo(click.style(crud_response['error_type'], fg='red'))
  File "/usr/local/lib/python2.7/site-packages/click/termui.py", line 393, in style
    return ''.join(bits)
TypeError: sequence item 1: expected string, NoneType found

Update without encrypting fields

Sometimes, it is useful to get an item from a cruddy handler, make some modifications and then update it. Same with list: iterate through and update specific items.

If there are any encrypted fields, the data from those methods above is not suitable to pass to update as it would result in the encrypted fields being double-encrypted. A get must be called with decrypt=True, and list has no such option.

One idea is to make it possible to update an item without encrypting fields. Perhaps

update(item, encrypt=False)

where this stores all fields in item verbatim in DynamoDB.

CLI increment returns null

It would be nice if when calling increment using the cruddy CLI that it returned the new number. Currently it just returns null