Giter Site home page Giter Site logo

Comments (9)

svenstaro avatar svenstaro commented on September 25, 2024 1

There is a use case which is that I use the ReleaseDate as a substitution marker for my automatic release tool. I imagine it's quite a common case and it doesn't really hurt to have that there. I'd like it to also work with your action as it worked before.

from changelog-reader-action.

svenstaro avatar svenstaro commented on September 25, 2024 1

Tested and looking good! Thanks.

from changelog-reader-action.

svenstaro avatar svenstaro commented on September 25, 2024

I just tested this on v1.2.0 of this Action and it works totally fine! I believe v1.3.0 is a bit broken perhaps.

from changelog-reader-action.

mindsers avatar mindsers commented on September 25, 2024

Thank for taking the time to report this issue.

It seems to be related to the SEMVER regex that has been updated in v1.3.0. I'm looking into it currently.

from changelog-reader-action.

mindsers avatar mindsers commented on September 25, 2024

@svenstaro I saw you use ## [Unreleased] - ReleaseDate as a title for your unreleased section. Can you try to remove the " - ReleaseDate" to see if it works for you?

Since v1.3.0 the parser tries to parse the date too and I guess it might fail to parse "ReleaseDate".

from changelog-reader-action.

svenstaro avatar svenstaro commented on September 25, 2024

I did it the reverse way: I added - ReleaseDate to your tests and it works fine which is weird. I didn't try removing it yet due to time constraints. Perhaps you could add my CHANGELOG to this repo in the test flow and see if it breaks and debug it that way? Seems to me that this would be a quicker turnaround for you while debugging this.

from changelog-reader-action.

mindsers avatar mindsers commented on September 25, 2024

Ok, just tried with your file. Check out the action logs:

It is working without the fake date. I wonder if there is a use case where we need to use fake dates...

from changelog-reader-action.

mindsers avatar mindsers commented on September 25, 2024

substitution marker for my automatic release tool

It's actually a great use case. So, I made a fix that make the action ignore the fake dates. I'll release it today I think.

from changelog-reader-action.

mindsers avatar mindsers commented on September 25, 2024

Fix released!! 🎉

from changelog-reader-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.