Giter Site home page Giter Site logo

Comments (2)

mindsers avatar mindsers commented on June 16, 2024

Hello, thanks for taking the time to open this issue (and the related PR). It is much appreciated.

This is an interesting case that I still don't know how to solve right now. I mean, this action pretend to work with projet following SEMVER rules and as far as I understand your link, the public version identifier of Pip project doesn't follow the SEMVER rules.

Right now, we use the REGEX provided by the SEMVER project to detect version numbers.

I'm wondering what is the best way to handle this:

  • modifying the REGEX (as you did) but it won't strictly detect and verify SEMVER version number anymore.
  • add support for other format
  • allow custom format
  • something else..

from changelog-reader-action.

mindsers avatar mindsers commented on June 16, 2024

Also, I just thought that it could break the linting part of the action because it needs to understand (for each format supported: currently only SEMVER) how major/minor/fixes/prerelease/etc are defined to be able to apply the correct linting rules.

We can update the part too if needed. That's not the problem. But we definitely have to take it into consideration too when deciding if (and how) we want to support other format or not.

from changelog-reader-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.