Moreblocks breaks dark green wool recipe/craft

[minetest-mods]

Moreblocks breaks dark green wool recipe/craft

[JDCodeIt]

This seems to be a weird side effect of the call to minetest.clear_craft. The bug was introduced with #124

If you comment out this in redefinitions.lua, the dark_green wool recipe works.

This could be a deeper bug in the clear_craft function, though.

[JDCodeIt]

In irc discussion today, p_gimeno found the root cause is in this version of minetest game, which essentially has created two recipes with the same input. One produces green wool, and the other produces dark green wool. The order of these recipes in the system were such that the dark green (proper) recipe occurred first. Calling the clear_craft function has the side effect of inverting the list of registered recipes so that the lighter green recipe came first.
MTG has been updated to remove the duplicate recipe input. See https://github.com/minetest/minetest_game/commits/6f80fd3737cd4de30e548dd48bc0ab8c288d9930

Thanks p_gimeno!

[Calinou]

@JDCodeIt Is this issue now solved in 5.0.0? If so, I'll close it.

Technically it's solved in MTG 5.0.0. See also minetest/minetest#8427 for the remaining bug.

Edit: To clarify, the remaining bug does not produce the effect reported here, but the reversal of the list caused by the clear_craft call may be causing side effects in other mods. But that's not for moreblocks to fix (unless a new bogus call to clear_craft is desired to re-reverse the list until 8427 is fixed).

[Calinou]

@pgimeno Thanks for clarifying this 😃 I'll close this issue now.