Giter Site home page Giter Site logo

Crash on startup about moreblocks HOT 7 CLOSED

OgelGames avatar OgelGames commented on June 22, 2024 1
Crash on startup

from moreblocks.

Comments (7)

Oblomov avatar Oblomov commented on June 22, 2024 1

Ah interesting. How is the width 0 though? Shouldn't it be 1?

EDIT: oh wait, width = 0 probably means that the recipe is shapeless. That definitely needs special handling.

from moreblocks.

OgelGames avatar OgelGames commented on June 22, 2024

@Oblomov

from moreblocks.

Oblomov avatar Oblomov commented on June 22, 2024

Hm this issue seems to be related to the interaction with a different mod. Can you please identify which mod is causing the issue?

from moreblocks.

OgelGames avatar OgelGames commented on June 22, 2024

I don't know, the above is from the CI for our mod collection, specifically this one: https://github.com/pandorabox-io/pandorabox-mods/pull/1286/checks?check_run_id=1629154050

from moreblocks.

Oblomov avatar Oblomov commented on June 22, 2024

Jeepers that's a lot of mods. However, I cannot reproduce with my setup, so I need someone to provide me with enough information do a repro, possibly without testing all of those mods. You probably want to look at mods that redefine/enhance signs or rails.

from moreblocks.

OgelGames avatar OgelGames commented on June 22, 2024

I modified the code to print out what recipes it was changing, and tested it locally with all the mods, and I found that it was this recipe that was causing it to crash: https://github.com/minetest-mirrors/ehlphabet/blob/277f31d6053a9ff6b75a76edf93e8f9cc7a492be/init.lua#L285-L289

Interestingly, this is how the recipe was dumped:

{
        width = 0,
        type = "normal",
        items = {
                "ehlphabet:block"
        },
        output = "default:paper",
        method = "normal"
}

Maybe the width should be checked, because that was the only recipe changed that had width = 0 ?

from moreblocks.

Oblomov avatar Oblomov commented on June 22, 2024

OK this should be fixed in #171. Of course the weird thing in this case is that crafting and de-crafting these blocks will basically provide infinite paper. We should probably have a mechanism to prevent some recipes from being pumped up. I'll open a separate issue about this.

from moreblocks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.