missing-q/emblem20

A Fire Emblem automated tabletop system for Roll20- https://missing-q.github.io/emblem20/

emblem20's Issues

HPCurrC is not defined when using Rally Skills

The error message I received was:
ReferenceError: HPCurrC is not defined
at skillMain (apiscript.js:4064:44)
at Skill (apiscript.js:4132:17)
at apiscript.js:4136:9
at eval (eval at (/home/node/d20-api-server/api.js:151:1), :65:16)
at Object.publish (eval at (/home/node/d20-api-server/api.js:151:1), :70:8)
at /home/node/d20-api-server/api.js:1634:12
at /home/node/d20-api-server/node_modules/firebase/lib/firebase-node.js:93:560
at hc (/home/node/d20-api-server/node_modules/firebase/lib/firebase-node.js:39:147)
at Kd (/home/node/d20-api-server/node_modules/firebase/lib/firebase-node.js:93:546)
at Id.Mb (/home/node/d20-api-server/node_modules/firebase/lib/firebase-node.js:93:489)
at Zd.Ld.Mb (/home/node/d20-api-server/node_modules/firebase/lib/firebase-node.js:94:425)
at /home/node/d20-api-server/node_modules/firebase/lib/firebase-node.js:111:400

Skill above 100% always give 2

When you level up and have the percentage above 100% it always gives +2. Looking at the code, on lines 1761/1762, you check if it's greater then 100 then you check if d100 is less then it but you haven't subtracted 100 yet, so it always passes.

Detecting magic weapons doesn't work

if ( (PhysWepTypes.includes(WTypeB))||(PhysWeps.includes(WNameB)) ){
DmgtypeB = "Physical";
DmgB = (StrB + MtB) - DefA;
} else if ( (MWepTypes.includes(WTypeB))||(MagWeps.includes(WNameB)) ){
DmgtypeB = "Magical";
DmgB = (MagB + MtB) - ResA;

as an example for the code above, If you had a flame shuriken, it would first check that it is a shuriken and make it a physical weapon then it would skip over checking that it name is "Flame Shuriken" because the first if statement was true.

Level up doesn't level Res even when it's at 100% chance

I was doing some testing and I realized that when a character would level up he would never get a point in res even at 100%. I tested it with other attributes but the rest of them works as intended.

Modify stats incorrect for dodge

emblem20/Basic Package/API Scripts/stats.js

Line 98 in a93e60d

if (hit > 0){

It's checking if hit > 0 where it should be dgg > 0

Incorrect to hit calculation

emblem20/Basic Package/sheet.html

Line 3927 in a93e60d

Hit: Math.round((Skl * 3) + wHit + (Lck / 2)) + Number(Mod)

To hit is meant to be (skill3+luck)/2+wHit (or skill1.5+luck*.5+wHit)