Filenames with "#" are not handled correctly

[SaswatPadhi]

Filenames with "#" are not handled correctly

[misterunknown]

This should not happen, because the hash sign gets url-encoded. Can you give some more information about your software (IFM version, webserver, OS, etc.)?

One test example can be found here, where both the directory and the file contains a hash sign:

https://ifmdemo.gitea.de/#D%25%26%24%C2%A7iy%3D)%D0%A1%D0%B0%D0%B9%D0%BD%20%D0%B1%D0%B0%D0%B9%D0%BD%D0%B0(%7B%7D%3F%60-.%2C%23%2B'*%22wh%5E%C2%B0sp%E5%A4%B1%E5%8F%8Bs%F0%9F%98%B1

(I cant link it directly because the directory also contains a closing bracket which interferes with the github markdown syntax, and I don't know how to escape that).

[misterunknown]

By the way: Can you fix this by setting forceproxy to true?

[misterunknown]

Any update on this?

[novashdima]

No, forceproxy didn't fix it
Check pull request 155, mb fix it.

I check w/ filenames:
new"file.txt new#file.txt new'file.txt newfil'\''_+="``'$'\321\227\321\224\321\215''e.txt newfile.txt#123

[novashdima]

Hmm... see another problem with ' (%27)

[misterunknown]

Hmm... see another problem with ' (%27)

Ok, which webserver do you use? I tested with apache2 and nginx, and there it works even without url-escaping single and double quotes.

[novashdima]

Hmm... see another problem with ' (%27)

Ok, which webserver do you use? I tested with apache2 and nginx, and there it works even without url-escaping single and double quotes.

Nginx 1.19.

Try to create new file from web panel, put single quote in filename, edit file by edit button and try to open this file by link.
In my case I see blank page (or empty file), but if I open it I see it's not empty.

Very strange, but from home PC all right...
Maybe browser cache :)

[misterunknown]

Hm, I can't reproduce this on https://ifmdemo.gitea.de or a test instance with nginx. What does

curl -i <url_to_file>

say?

By the way: I don't have any strong opinions on this; if you want to add single and double quotes escaping to hrefEncode feel free :)

[SaswatPadhi]

Hi,

Sorry for the delayed response! This week has been super busy. I am running IFM within docker(Dockerfile). You could test with this image.

Also how / where do I set forceproxy?

Thanks!

[novashdima]

Hm, I can't reproduce this on https://ifmdemo.gitea.de or a test instance with nginx. What does

curl -i <url_to_file>

say?

Checked on work PC now - all right.
Maybe it's really was browser cache.

By the way: I don't have any strong opinions on this; if you want to add single and double quotes escaping to hrefEncode feel free :)

Yes, I know, thx :)

[novashdima]

Also how / where do I set forceproxy?

In array $defaultconfig in php file, line 59.
Also check fix in latest commit in master.

[misterunknown]

Also how / where do I set forceproxy?

You can set this with environment variables in docker using -e IFM_GUI_FORCEPROXY=1.

[misterunknown]

But @novashdima is right, this is caused by an older IFM version which has this bug. I just tested it with your docker image.

I really should release a new version soon, since there were already some bugfixes and changes.

If you want to fix this you have two options:

• use the official docker image here. This image is build based upon this repository, and contains the latest changes.
• edit your image to compile and use the latest IFM version