Giter Site home page Giter Site logo

Picture previews won’t close about ifm HOT 5 OPEN

maggie0002 avatar maggie0002 commented on May 27, 2024
Picture previews won’t close

from ifm.

Comments (5)

novashdima avatar novashdima commented on May 27, 2024

Hi, @maggie0002.
On my mobile chrome if I click on picture I get this picture as new web page without popover.
I try to disable popover on mobile, check my changes in pull request #161.

from ifm.

misterunknown avatar misterunknown commented on May 27, 2024

I can't confirm that, since I have no iphone; on android there is no preview. But I guess the pull request from @novashdima (#161) should solve that.

from ifm.

maggie0002 avatar maggie0002 commented on May 27, 2024

Hi, @maggie0002.
On my mobile chrome if I click on picture I get this picture as new web page without popover.
I try to disable popover on mobile, check my changes in pull request #161.

Checked it with that pull request and has resolved the issue. Only tested on iPhone 12 mini using Safari, but think it's safe to assume it will be ok now for other iPhones too. Tested it loading the page which defaults to the 'mobile version', then requested Safari fetch the 'desktop version' of the website, which also appears to be problem free.

Thanks.

from ifm.

maggie0002 avatar maggie0002 commented on May 27, 2024

I just discovered that this is happening occasionally on the desktop too. Using Safari I occasionally find images stuck on the screen. You can navigate in and out of folders and it remains there the whole time until you refresh the page. Not sure how to reproduce it exactly, but clicking around in and out of folders and files while intermittently hovering to display a picture and it occurs (in Safari at least).

Not sure what to suggest, as for mobile it was decided just to disable it rather than try and fix it. Perhaps worth considering whether this feature brings any significant benefit, it may be more trouble that its worth? I see value in being able to preview files, but perhaps a thumbnail view as an alternative to the last view would be more valuable anyway. Alternatively, could try upgrade to v2 of popper (https://popper.js.org/docs/v2/migration-guide/)?

Screenshot 2021-01-27 at 17 25 34

Screenshot 2021-01-27 at 17 25 56

from ifm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.