Giter Site home page Giter Site logo

Comments (9)

m0dB avatar m0dB commented on July 28, 2024 1

Thanks for looking into this, @ronso0. If you get stuck, let me know; while I am certainly not an expert on this part of the code base, I have been looking at it quite a bit recently :-)

from mixxx.

ronso0 avatar ronso0 commented on July 28, 2024

Can confirm the playcount issue, repaint on selection change (bold) works though.

Crates are not affected, so it's probably some issue in PlaylistFeature::slotPlaylistTableChanged and/or PlaylistFeature::constructChildModel

from mixxx.

m0dB avatar m0dB commented on July 28, 2024

(Thanks @ronso0 for spotting the duplicate bug report)

As I have been watching this behaviour closely while working on #12020 , I am sure this was working correctly not too long ago.

from mixxx.

m0dB avatar m0dB commented on July 28, 2024

I am removing the Qt6 tag, as I am sure it worked correctly with Qt6, so I doubt it is Qt version related.

from mixxx.

ronso0 avatar ronso0 commented on July 28, 2024

Can confirm the playcount issue, repaint on selection change (bold) works though.

Crates are not affected, so it's probably some issue in PlaylistFeature::slotPlaylistTableChanged and/or PlaylistFeature::constructChildModel

or

QString PlaylistFeature::fetchPlaylistLabel(int playlistId) {

or there's an issue in PlaylistDAO.

from mixxx.

ronso0 avatar ronso0 commented on July 28, 2024

Damn, stupid typo 🤦‍♂️
8b79278

I'll push a fix asap

from mixxx.

ronso0 avatar ronso0 commented on July 28, 2024

but something else is wrong... I'll take a look.

from mixxx.

Eve00000 avatar Eve00000 commented on July 28, 2024

Oh, there(s something going on here :-)
not as easy as you thought?

from mixxx.

ronso0 avatar ronso0 commented on July 28, 2024

I'm still not sure how this broke (currently bisecting), but a simple m_pSidebarModel->triggerRepaint() after updating the tree item label fixes it. Seems setting the label does not make the model emit dataChanged(index).

from mixxx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.