Comments (6)
Hey @laurent-bientz !
This is probably when you save the file with an empty body, I will try to make the error appear without crashing for the next release tomorrow!
Regards,
Guillaume
from mjml.
@GuillaumeBadi : I believe you're correct about it being empty tags. I can confirm that using --watch
with the following causes an error:
<mj-body>
<mj-section>
<mj-column>
<mj-text align='left'></mj-text>
</mj-column>
<mj-column>
<mj-text align='right'></mj-text>
</mj-column>
</mj-section>
</mj-body>
However, adding text to the mj-text element fixes the problem and an error is not thrown. The error I'm receiving is different though:
Warning: React.renderToStaticMarkup is deprecated. Please use ReactDOMServer.renderToStaticMarkup from require('react-dom/server') instead.
Invariant Violation: renderToStaticMarkup(): You must pass a valid ReactElement.
from mjml.
Hello and thank u for your feedback.
I can't test today but to reproduce the glitch, just put some spaces in your file.
For me, it's crashed and no memories about an empty <mj-body>
or <mj-text>
.
Btw, i can remember that empty <mj-text>
also crashed with basic command line (mjml -r test.mjml --output test.html
), so I don't think it's linked to the same pb, maybe i'm wrong.
I'll check next monday
from mjml.
Empty mj-text
is now fixed ! Please reopen if you're still having the issue with 1.2.0
from mjml.
Plus the client won't crash anymore and simply log the error message if any 😄
from mjml.
👍
from mjml.
Related Issues (20)
- `mjml2html` render in web worker throws `Uncaught ReferenceError: window is not defined` HOT 2
- Support DATA variable in href or button HOT 1
- Icon with text/Column within Column HOT 1
- Dependency: html-minifier REDoS vulnerability HOT 4
- No padding on outlook HOT 8
- Helper UrlEncode does not return the expected result HOT 3
- Empty "lang" attribute on mjml element is rendered as invalid lang="und" HOT 3
- Mobile customization issue. HOT 2
- Example of how to add color variables HOT 1
- MJML Table Data not rendered in newer Outlook versions using WebView2 (Desktop and Android) HOT 14
- how to add a helper container for an image so it can be centered between elements. HOT 1
- Custom mj-head component causes TypeError: this.context.processing is not a function HOT 8
- Outlook 2404 build 17531.20119 not rendering MJML template HOT 10
- MJML Templates not rendering as expected in New Outlook on Windows HOT 4
- Wrong vertical-align in mj-column HOT 1
- Outlook web client doesn't render columns HOT 5
- mjml column is not working in hotmail
- Invalide Certificate HOT 8
- Try it live does not allow pasting HOT 3
- HTML Comments rendered with additional white space HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mjml.