mkesicki/excel_validator

Python script to validate data in Excel files

excel_validator's Issues

Excludes columns are still validated

Exclude columns are still validated if the columns have blanks though it states that #default validator is used for not excluded columns for which no other validation rule is set
Code: excludes: ["L","M"]

Only if I remove the below code, the column validations excluded

default:
- NotBlank:
message: Value can not be blank

Add logger for messages & output

excel script

Add possibility to just print errors , do not create excel files with errors

--dry-run ?

Name/Type of validator is set wrong if column has more than one validator

It is always set for first validator for column example:

        C:
            - Type:
                type: integer
                message: "Message"
                trim: true
                
        - Conditional:
                message: "Message"
                fieldB: "C"
                operator: "lambda c, d: (False if (c > d) else True)"
                trim: true 
        D:
            - Type:
                type: integer
                message: "Message"
                trim: true

in this case conditional validator will be not set

Add possibility to use more than 1 defualt validator

For now only one default validator can be used.

Addressing error file size limitation

excel_validator/excel_validator.py

Line 282 in f1ef759

sys.exit("Invalid file is too big to generate annotated Excel file")

Hi,

I think this is a great tool, but there seems to be a limitation regarding the binary size of the error Excel file.

If I try to run against an input file that is between 76 -- 100 megabits Excel file, I receive an error saying that the output error file is too large and thus cannot be created.

As a user (with sufficient resource) my expectation is for a file to be generated.
Does anyone more versed in the code of the solution and/or supporting libraries provide me with enlightenment on how to bypass this situation?

Thank you.

Add tests

Use https://docs.python.org/2/library/unittest.html or something similar.

Python3

Dear,
I was testing your script but it seems to fail with python 3.
Dict variables are not supported.
I'm getting errors on type = settings.keys()[0]

Cleanup code - looks like it was write late at nights