ml-in-barcelona/react-rules-of-hooks-ppx

This ppx validates the rules of React hooks.

react-rules-of-hooks-ppx's Issues

"Error: Hooks can't be inside conditionals, neither loops." with React.useMemo0 hook

The following code:

@react.component
let make = () => {
  let className = React.useMemo0(() => "rescript + react + emotion + styled-ppx rocks!")
  <div className />
}

...triggers an error:

3 |   let className = React.useMemo0(() => "rescript + react + emotion + styled-ppx rocks!")
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Hooks can't be inside conditionals, neither loops.

Use register_correction

Instead of register_transformation and raise error, use register_correction which suggest the corrected AST to the user. Still not sure how the correction pops up in the editor/console but depending if this is useful would be really benefitial.

In the exhaustive dependencies in useEffect, it should print the expression with the new dependency array and the new useEffect{{number}} fn name.

Check useEffects idents inside Pexp_match/Pexp_try cases which will have expressions

This case should trigger the error:
https://astexplorer.net/#/gist/d5cd3f97af21bfa2ab1621f8e8f5eb04/a12ab711bccafd83daf14bd2a531c589ff376e44

Right now we ignore the matches and try catches.