ml4ai/dass-wills

dass-wills's Issues

file name for output pickle file

@pawnsac Thanks for the code. I have a couple of minor tweaks I'd like to request:

1. Right now the name of the output pickle file is derived from that of the input JSON file. This potentially has the disadvantage that for an input JSON file will01.json the piclke file is named will01.json.pickle, which can be confusing by making it seem as though it's the JSON file that's being pickled. Would it be possible to name the output pickle file by removing the .json suffix from the input JSON file, i.e., if the JSON file is will01.json then the output pickle file is will01.pickle.
2. In the output line printed by the program, exporting the will object... can you just add the name of the file being exported to?

devolve_will.py

@pawnsac The file devolve_will.py has a few style issues that should be fixed. Where possible let's try to be consistent with PEP-8 (https://peps.python.org/pep-0008/).

• Maximum line length = 79 (https://peps.python.org/pep-0008/#maximum-line-length)
• Adjacent function definitions should be separated by two blank lines (https://peps.python.org/pep-0008/#blank-lines)
• The file has a banner "UTILITIES" near the top but no other banners, suggesting that the file consists entirely of utilities and nothing else.
• Please check the import statements at the top to make sure they make sense. For example, Person is imported but it's not used in the code.