mlanghof/mp3ror

mp3ror's Issues

Last header may be discarded

The current check for whether a 4 byte sequence is a header includes checking if the frame described by it would be immediately followed by another header-like sequence, or the end of the file. If there are non-header bytes at the end of the file (e.g. ID3), the last header is therefore erroneously discarded.

This check does eliminate a few "false" headers that could appear in the byte stream and happen to pass all the other sanity checks (meaningful bitrate etc.).

Maybe the solution is to skip forward in entire frame lengths once we are "locked into" the frame sequence and assume that everything that follows a frame and looks like a header is a header. The question is how to discover the starting point (maybe only do the above check while trying to "lock in"?).

Support CRC

noLove.mp3 has CRC enabled, implement and test it with that.