mliarakos/lagom-js

Scala.js client for Lagom

lagom-js's Issues

Scala 2.13 Support

Update lagom.js to support Scala 2.13.

Lagom.js depends on Akka.js, which is still working on Scala 2.13 support (see this comment in akka-js/akka.js#103).

Once that is resolved it should be as simple as adding Scala 2.13 to scalaVersions in build.sbt:

val scalaVersions = Seq("2.12.10", "2.13.1")

Evaluate back-pressure implementation for sending side WebSocket messages

Currently, the lagom.js WebSocket client does not support back-pressure for sending or receiving messages over the socket. As described here, back-pressure for receiving messages is not possible under the current WebSocket standard.

However, it is possible to provide back-pressure for sent messages using WebSocket.bufferedAmount, as described here. We should evaluate if sending side back-pressure can be implemented using this approach.

Implement Circuit Breakers

The feature/circuit-breaker branch contains a mostly working implementation of circuit breakers for Lagom.js. The outstanding issues are:

• Implement java.util.function.Consumer - see scala-js/scala-js#3916 and akka-js/akka.js#109
• Resolve IllegalStateException issue - see akka-js/akka.js#108

The CircuitBreakerMetricsProviderImpl is a no-op implementation that doesn't actually collect any metrics because the metrics library used by Lagom isn't available for Scala.js. I need to work on a real implementation, but it isn't critical to releasing the actual circuit breaker functionality.

Client header parsing fails on empty header

The ClientServiceCallInvoker.parseHeaders method fails if there are no response headers or if a header is empty. The method assumes headers will have the form "key: values".

The method uses xhr.getAllResponseHeaders() to get headers. In some cases a request will fail with no response headers (e.g., CORS issue), which causes getAllResponseHeaders() to return an empty string and the method to fail. Additionally, if a header was ever empty it would also cause the method to fail.

Complete WebSocket Client Implementation

The WebSocket client implementation is missing some important features. It needs to:

• handle binary data
• handle socket close to determine if the socket failed
• parse exceptions

Client fails with IllegalArgumentException on AJAX timeout

When a client AJAX request fails by timeout it has status code 0. The Lagom TransportErrorCode.fromHttp method throws an IllegalArgumentException for status code 0, which obscures the AJAX timeout.

Update to lagom 1.5.5

https://github.com/lagom/lagom/releases/tag/1.5.5

I'd be happy to assist with some guidance.

update to lagom 1.6.5

I've already prepared a PR on akka.js to update it to 2.6.14. I guess that's a dependency for lagom.js 1.6.5?

Update to lagom 1.6.0

https://www.lagomframework.com/documentation/1.6.x/java/Migration16.html
https://github.com/lagom/lagom/releases/tag/1.6.0

I guess we need to wait for akka-js/akka.js#103 first. After that I'd be happy to assist here too :)

Provide convenient access to the default client config

Due to akka-js/shocon#55 adding client settings to the lagom.js client config is difficult. Lagom.js should provide access to the default client config so it can be used by user, similar to Akka.js:

lazy val conf =
  ConfigFactory
    .parseString("""
    akka {
      loglevel = "DEBUG"
      stdout-loglevel = "DEBUG"
    }""")
    .withFallback(akkajs.Config.default)

lazy val system = ActorSystem("yourname", conf)

Looking forward

Stepping by just to say that I love this project!
I would love to speak with you about what you are trying to achieve and obvious dependencies on akka.js to support as much as I can. You have my personal email in my GitHub profile or you can reach out on Gitter or Twitter as you prefer!
Cheers!