set_params

[mlr-org]

set_params

[mllg]

If you want to have a method, how about implementing the method in the param set, e.g. learner$param_set$set_params()? It wouldn't make sense to have all methods to work with parameters inside param_set except one.

[sebffischer]

Good point, on the other hand this is really the only way a user ever interacts with the param set so maybe it is ok to make this exception / do both?

I feel that
learner$set_params(x = 1)
is more user friendly than
learner$param_set$set_values(x = 1)
but I would be ok with your suggestion.

In any case as a first step I would add the method and call it set_values to make it consistent with the getter get_values.

[sebffischer]

Ok actually I fully agree with you.