Partial argument matching for dictionary sugar get

[mlr-org]

Partial argument matching for dictionary sugar get

[mb706]

maybe better to create a new function dictionary_sugar_get_safe and remove the old function after a few versions, this way we don't all have to upload new packages

[mllg]

Can you provide a reproducible example for this?

[sebffischer]

library(mlr3misc)

dictionary = Dictionary$new()

dictionary$add("a", function(di) print(dictus))


sgr = function(.key, ...) {
  dictionary_sugar_get(dictionary, .key, ...)
}

sgr("a", di = "hallo")
#> Error in dictionary_sugar_get(dictionary, .key, ...): Assertion on 'dict' failed: Must inherit from class 'Dictionary', but has class 'character'.

^{Created on 2023-07-06 with reprex v2.0.2}

[sebffischer]

The additional di = "hallo" partially matches the dict argument from dictionary_sugar_get.
We could just call the dict argument .dict.

[mllg]

Agreed - can you PR this?

[sebffischer]

We need to sync package releases though: https://github.com/mlr-org/mlr3pipelines/blob/dae03afd8efa83621a495a058f42cfc2ea8d7357/R/ppl.R#L26

Or we add an

if (packageVersion("mlr3") > ...) 
  use .dict
else
  use dict

to the relevant functions