mmontone/clavier

:heavy_check_mark: General purpose validation library for Common Lisp

clavier's Issues

error-p option in make-instance

I want to use validator like this

(let ((validator (make-instance 'boolean-validator :error-p t)))
    (funcall validator "hi"))
=> #<VALIDATION-ERROR hi: hi is not a boolean {1003B01EF3}>

What do you say to this option?

How would you allow a blank field and validate if non blank?

Say we have a form field that can be empty, but when non empty it should be validated. Can we express that?

I tried with a || and non-blank or blank but it isn't the right logic.

Is this expected to be done on this layer?

---

I can add this meaning on my side, but this looks like it should be done inside the validation library.

(defun my-validators ()
  (dict 'isbn (list :allow-blank
                    (clavier:not-blank)
                    (clavier:len :min 10 :max 13))
  …))

…

      (loop for validator in (validators)
            if (and (eql :allow-blank validator)
                    (str:blankp val))
              return t
            else
              do (unless (keywordp validator)
                   (multiple-value-bind (success msg)
                       (clavier:validate validator val)
                     …

Best,

---

I tried to create a new validator class, but this won't compile:

Cannot CHANGE-CLASS objects into CLASS metaobjects.

(defclass allow-blank-validator (validator)
  ()
  (:metaclass closer-mop:funcallable-standard-class))

LEN validator: no message, min-message and max-message are not displayed

Hello,

it seems that :min-message and :max-message are not displayed. Also why not have a :message?

(defun len (&key min max message min-message max-message)
  (make-instance 'length-validator
		 :min min
		 :max max
                 :message message  <---- adding message but this creates an error on validation.
		 :min-message min-message
		 :max-message max-message))

(will send PR later if I confirm the needs)