mnabe/xpend

Sample application for expense management, based on the hexagonal architecture/ports and adapters-pattern.

xpend's Issues

A user can edit an existing expense

Make GetExpense-endpoint asynchrounous

The whole request flow needs to support async/await pattern, so that the thread is not blocked while waiting for response.

Make all endpoints non-thread blocking (async/await)

Implement tests for fails/exceptions

In all test classes that doesn't currently have it

A user can create an expense

Improve implementation of "InternalsVisibleTo"

• Research better ways to place [InternalsVisibleTo()] annotations. They are currently placed in IServiceCollectionExtension.cs and ExpenseCategoryService.cs
• Based on research, make an implementation

Create tests/test classes for services that are missing

It is mostly service-classes, that are not covered.

Implement proper repository with unit of work

Implement exception handling in GetExpense-endpoint

Complete input validation

Use the library FluentValidation - Website, GitHub - to/for complete input validation.

Provide the expense-id for a new expense on POST requests

When creating a new Expense, the id in the response to the client displays 0.

Implement a new business area

Tasks

• New separate bounded context for another business area
• Join data with expense context (separate/split database)

Add authentication and possibly authorization

Make all endpoints adhere to principles of REST

Move ExpenseCategoryService to domain-method

Refactor domain test afterwards

A user can retrieve a specific expense, that they've had

Make full DDD-implementation

Extension of #11

Implement business logic in domain for VAT-deduction in Denmark

If an employee is on a business trip in Denmark, you can deduct 25% of the VAT. This could be for eating at a restaurant or hotel - note, that snacks/drinks from a hotel minibar isn't included, since the expense doesn't stem from restauration.

In general, expenses from restauration services usually allow for 25% VAT-deduction, e.g. business meetings that are not business trip per se, when it serves a purpose for the business.

Finally, food-expenses stemming from sudden/abrupt overtime work also qualifies as VAT-deductible (not overtime-work in itself, however).

A user can retrieve a list of all expenses, that they've had