mnasyrov/karma-jasmine-spec-tags

A plugin for karma-jasmine which helps to filter tests (specs) by tags.

Hello 👋

I'm a lead software engineer and have extensive experience in web development: from backend servers to frontend applications. And I like to develop new products and create open-source tools.

My languages are JavaScript, TypeScript, Java, C# and Python.

You can follow me on LinkedIn.

karma-jasmine-spec-tags's Issues

Getting and setting `specFilter` directly from `Env` is deprecated in Jasmine 3.3.0

First of all, thank you for creating this helpful utility!

Issue:

With Jasmine 3.3.0 getting and setting specFilter directly from Env is deprecated. This method was deprecated in the following commit: jasmine/jasmine@92d0882. When using this utitlity and version 3.3.0 of Jasmine or higher we get the following deprecation warnings:

'DEPRECATION:', 'Getting specFilter directly from Env is deprecated, please check the specFilter option from `configuration`'
'DEPRECATION:', 'Setting specFilter directly on Env is deprecated, please use the specFilter option in `configure`'

Proposed Fix:

Update lines 20 - 21 of client.js from:

    var specFilterFnDelegate = jasmineEnv.specFilter;
    jasmineEnv.specFilter = customSpecFilter;

to:

    var specFilterFnDelegate = jasmineEnv.configuration.specFilter;
    jasmineEnv.configure({ specFilter: customSpecFilter });

Also, add the following jasmine peerDependency to package.json:

    "jasmine": "^3.3.0",

Note:

I'm happy to send a pull request with these changes; however, I believe I do not have permissions to do so at this time.

Thank you!

update jasmine dependency version

npm WARN Could not resolve dependency:
npm WARN peer jasmine@"^3.3.0" from [email protected]

For me this package works fine with jasmine 4.4.0.

Karma 6.0.0 gives error Unknown arguments: skip-tags, skipTags

Karma 6.0.0 introduced a breaking change where the cli errors on "unexpected options or parameters". This results in the following error in the console with karma-jasmine-spec-tags:

Unknown arguments: skip-tags, skipTags

Tags not ignored with karma-jasmine 3.1

While updating my devDependencies to latest I found that if I update karma-jasmine to latest (v3.1.0) that my --skipTags are no longer functional.

Staying at karma-jasmine 2.0.1 or upgrading to karma-jasmine 3.0.3 seem to work with karma-jasmine-spec-tags but when using karma-jasmine 3.1.0 my skipped tags are no longer skipped.