mnewberg/whitmanc.github.io

Pulse.fm website

whitmanc.github.io's Issues

Mobile mute button not maintaining state on mobile

@whitman Could you please remove the speaker icon on mobile?

Military time not standardized

@whitmanc Can you please use something like UTC time? My understanding is that the current code does not account for time zones, so it's purely based off of the user's browser's time?

e.g. If I set a store's hours to 900, it will only show for 9am in all time zones, regardless of where I am as a user

Player not maintaining proper state in edge case

@whitmanc I just found the following issue. Here's steps to replicate (you can test it out live on my site here: http://pulsestaging.s3-website-us-east-1.amazonaws.com/

1. Click stream A, starts playing, then pause it
2. Click logo to go back home
3. Click stream B, player is still set to stream A

Note this only happens if you navigate back home after pausing, not if you're already playing a station... there should be no case in which you would be able to get another venue's stream played on a particular venue page.

Instructions for running the app

Should include how to install dependencies (i.e., compass gem) and how to run the server

Show loading indicator if stream is loading

@mnewberg
Put in a loading indicator for when a stream is loading. Thought this would be good for the ux.

Can be tested by clicking a venue play button on the venue list (home) page. A loading indicator should show on the fixed footer toolbar for radio controls as an overlay over the venue thumbnail.

Let me know if it should be removed.