mo22/jnipp

C++11 JNI wrapper

jnipp's Issues

Build instructions inadequate

The closest I could get to building with gcc or clang is as follows:

g++ -std=c++11 -fvisibility=hidden -fvisibility-inlines-hidden test.cpp _java.cpp -o test -I .. -I /usr/lib/jvm/default-java/include -I .

I need the "-I" include the jni headers, but this will need to be adjusted per platform. Perhaps a build system, like cmake and find_package command could be used to facilitate this. Also, "_java.cpp" was not included and needs to be.

generate/generate does not run on system with minimal sh

The generate script should state that needs bash if it needs bash.

Resolve return temporary todo

On line 299 there is a todo. This likely needs to beremoved. The commented code cannot work correctly, the destructor for std::string is allowed to (expected to?) free the memory that is pointed at by the return of string::c_str().

/*
    // @TODO: this is buggy.
    const char* c_str() const {
        std::string tmp = std_str();
        return tmp.c_str();
    }
*/

Won't compile outside android project.

Stray android include around line 63 of jnicpp.h

Compilation warning using #elif JNIPP_USE_TYPE_TRAITS

Should be either an #else or an #elif defined. I have sample fixed for this at: https://github.com/Sqeaky/jnipp/blob/master/jnipp.h