moggers87/smallquery

smallQuery, like jQuery but small.

moggers87

Hey it's me.

I write code for living. Send me money or consider hiring me if you like my work.

Latest releases

• django-sendfile2 0.7.1 released on 2024-02-17
• django-two-factor-auth 1.16.0 released on 2024-02-03
• Inboxen deploy-2023.11.27.20.52.7 released on 2023-11-27
• Inboxen deploy-2023.9.12.15.59.8 released on 2023-09-12
• Inboxen deploy-2023.9.5.10.25.4 released on 2023-09-05

From moggers87.co.uk

• (art) Penguin posted on 2022-04-05
• (art) Ribbons posted on 2021-10-07
• (food) Harissa lentil pot posted on 2021-09-13
• (food) Chickpea burger posted on 2021-09-13
• (food) Sweet potato wedges posted on 2021-09-13

smallquery's Issues

clone function

Make a deep copy of a smallQuery object.

Split plugins into separate files

Check setData for "prototype pollution"-type bugs

The setData function doesn't do any checking of the key we set. If this is user provided it could have some unexpected consequences.

1. Check that this function can actually be abused in this way
2. Fix it (by disallowing __proto__ as a key) if required
3. Look elsewhere in smallQuery to see if similar problems

smallQuery/smallquery.js

Line 131 in 1725810

function setData(el, key, value) {

Implement data() API

Implement this API as used by jQuery

Ajax?

First, I need to work out what is the "correct" way to use that API in jQuery (some ways of using it are deprecated I think?).

Second, will it be too much work to implement?

data functions should return something that isn't undefined

before/after

Tests

We need some basic tests

Remove event handlers

Implement an off method

Add keywords to package.json

See https://docs.npmjs.com/files/package.json#keywords

Tests for noConflict not showing up in coverage

They're missing and we should write some

removeData

The opposite of $().data

Add readme and some basic docs

not function

Remove matching element from the current set of elements. Especially useful as we don't have the :not() selector (it's not supported by browsers)

Implement noConflict?

jQuery has a noConflict function to "Relinquish jQuery's control of the $ variable"

Apparently other libraries alias things to $ too, so this code may be necessary when combing smallQuery with other libraries.

removeData should accept a list of keys to delete

prepend/append

Documentation

We should document this.

Modularise and use ES6+ features

Sticking with ES5 for development is getting hellish and sticking to just one JS file is also becoming problematic.

$(selector).each functions are passed the current element twice

this and the fist argument reference the current element. The first argument should be the current index.

smallQuery/smallquery.js

Line 55 in ad3bc67

if (fn.call(this[i], this[i], i) === false) {

remove function

Remove DOM elements

• remove
• detach
• empty

Code coverage

Use codecov to get coverage reports on PRs

wrap function

Complements before/after and prepend/append

Implement CSS APIs

• css()
• addClass()
• removeClass()

Event registering and triggering

Via on() and trigger(), it's easy enough for users to implement their own event specific plugins, e.g. click() if they wish.

children(), find() and friends.

• children()
• find()
• siblings()
• parent()
• parents()

Travis

Get both Firefox and Chrome tested on Travis.

I have other projects that test via Firefox on Travis, but never got Chrome working. It's not really an option to ignore Chrome here as we're not relying on jQuery ☺

each should return this

Limit which files are included in published package

See https://docs.npmjs.com/files/package.json#files

replaceWith function

Replace matched elements with content specified by function.