mohammedfaragallah/feathers-authentication-management-ts

Hi there 👋

My name is Mohammed

https://fregoclient.herokuapp.com

https://fregoadmin.herokuapp.com

https://expo.io/@mohammedfaragallah/projects

I'm a Software engineer with 3+ years of experience in web development, and 10+ years of multi-faceted background in Information technology (Technical support, Networking, Systems administration,...).

Tech-savvy been around computers since I can remember I love solving problems, learning new things, and the company of smart people.

Software engineer specializing in web development. Experienced with all stages of the development cycle for dynamic web projects. Well-versed in numerous Libraries/Frameworks. Strong background in project management and customer relations.

I don't consider myself to be an expert with every topic, but I'm extremely passionate, Obsessed with writing clean performant code and building things people use.

feathers-authentication-management-ts's Issues

resetToken validation

• I'm submitting a ...
  [ x ] bug report
  [ ] feature request
  [ ] question about the decisions made in the repository
  [ ] question about how to use this project

• Summary

The resetToken validation is not working properly.

• Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

Hi, I'm using this library and noticed that when I reset the password and send a different token than the one generated, the service still changes the password.
Looking into the code, I noticed that the helper for compare passwords, simply uses the bcrypt compare function, but this function doesn't raise an exception nor rejects the promise when pasword and the hash don´t match, it simply resolves the promise to false, and the reset pawwsord function has the "invalid token" management inside a catch (which doesn't run if the password doesn't match with the hash)
In the js version of the module, this case is managed properly (probably it wan changes after porting it to TS) by returning a promise that is resolved when the bcrypt.compares resolves to true and is rejected when resolves to false.
Here is the code (I havent't tested it but for what I see, it should work well) https://github.com/feathersjs-ecosystem/feathers-authentication-management/blob/master/src/helpers/compare-passwords.js
In the project where I'm using this module, I resolved it by attaching a before hook and managing there this case by including the bcryptjs in the main project.

I hope my comment helps to solve this issue

A functional example implementing this library?

• I'm submitting a ...
  [ ] bug report
  [x] feature request
  [ ] question about the decisions made in the repository
  [x] question about how to use this project

• Summary

After struggling to get the original feathers-authentication-management with feathers in ts I discover this project.

Is there somewhere a functional exemple showing an implementation of feathers-authentication-management-ts ?

could I help put one up?

Could I get some help for putting one up?

Thanks

How do you validate the token?

• I'm submitting a ...
  [ ] bug report
  [ ] feature request
  [ ] question about the decisions made in the repository
  [x] question about how to use this project

• Summary
  First of all, thanks for this cool project. It's a hassle to get the original JS project in a TS Feathers 4 project.
  Please provide an example how to validate the token.

Thanks