moizmali/siddhi-json-structs

siddhi-json-structs's Issues

Capitalize all fixed string values

There are places where fixed strings are used.

Eg: Window-Filter-Projection input type query's config is:

{
    type*: 'window-filter-projection',
    ...
}

Changing the type as WINDOW_FILTER_PROJECTION will make it easier to define enums and use.

Every such fixed strings can be named in this manner.

Note: Anyhow, comparisons are case insensitive

Improvement for pattern query input type config

JSON structure for the Pattern Query Input type is currently as follows:

{
    type*: 'pattern',
    eventList*: [
        {
            type*: 'default | andor | notfor | notand',
            value*: {Default JSON | ANDOR JSON | NOTFOR JSON | NOTAND JSON}
        },
        ...
    ]
}

Here, the type and value of a member in the eventList are transitively dependent. Isn't it good to make it like this:

{
    type*: 'pattern',
    eventList*: [
        {Default JSON | ANDOR JSON | NOTFOR JSON | NOTAND JSON},
        ...
    ]
}

And the Default JSON will be as follows:

{
    type*: 'default'
    forEvery*: 'true|false',
    eventReference: '',
    streamName*: '',
    filter: '',
    minCount: '',
    maxCount: ''
} 

ANDOR, NOTFOR & NOTAND will be having type inside them

Select in query in not mandatory.

A query without a select clause can exists.
Check in the following siddhi app in Product- SP.

@App:name("sample")
@App:description("Description of the plan") 

define stream TradeStream (symbol string, price double, volume long, timestamp long);

from TradeStream
insert into b;

Display The `Contents` Section Of The ReadMe In More Detail

Accommodate 'forEvery' in all the event values of SEQUENCE query input

The every keyword can be present for the first event of a Sequence Query Input type, regardless of its type.

(The following Compiles successfully)

Only counting value has forEvery key in its JSON config.
JSON configs of ANDOR, NOTAND & NOTFOR values should accommodate this

Accommodate isString enabled values to sources, sinks & similar places too

isString capability can also be possible in sources & sinks too. (eg: static_option=value). This value can be either a string or not.
There can be other places than sources & sinks too.
Find suitable places like this and update necessarily.

Aggregation Definition - Rename Timestamp variable

    aggregateBy: {
        timeStamp: 'timestamp',   // NOTE HERE
        timePeriod: 'sec...year'
    },
    store: {},
    annotationList: []
}

Can we replace timestamp with attribute?
Then it'll be

    aggregateBy: {
        attribute: 'timestamp',   // NOTE HERE
        timePeriod: 'sec...year'
    }

The Siddhi runtime identifies the variable as aggregateAttribute