Comments (2)
we think the best way forward would be to put system-specific guidance in the Docs... and remove these steps from the bash script
I don't see any advantage to doing this. If the person is using Mac and Homebrew, the current script makes things more convenient than having to follow manual instructions.
In the other thread, you said:
(We don’t as use conda so a conda only option wouldn’t work for us).
Just because you don't use conda now doesn't mean you couldn't start, and it would remove all this complexity, since it is cross-platform. But if you don't want to use conda, it could at least be added in addition to Homebrew in the script so it is an option. No harm in that, and as I said I'd be happy to contribute it. In fact, doing so would be quite simple: I'd just add aspell and go-yq to the existing conda quickstart instructions, and then skip that part of the script if aspell and yq are already present.
Lastly, I am still confused about the LibreOffice dictionaries (not the custom dictionary for Splink). From what I can find online, aspell does not support .aff files, so I don't understand how that is working. And the LibreOffice dictionaries don't seem to be necessary: I now get Spelling check passed :)
in the master branch, despite having commented out those lines of the script entirely.
from splink.
I don't see any advantage to doing this. If the person is using Mac and Homebrew, the current script makes things more convenient than having to follow manual instructions.
The original rationale for doing things this way was because the installs are a one-off and it lessens the burden of script/documentation maintenance when we can instead point to external documentation owned by package/package manager creators.
Just because you don't use conda now doesn't mean you couldn't start, and it would remove all this complexity, since it is cross-platform. But if you don't want to use conda, it could at least be added in addition to Homebrew in the script so it is an option. No harm in that, and as I said I'd be happy to contribute it. In fact, doing so would be quite simple: I'd just add aspell and go-yq to the existing conda quickstart instructions, and then skip that part of the script if aspell and yq are already present.
Appreciated. However unfortunately conda isn't something we are planning to adopt (at least not any time soon) so many thanks for your contribution in PR #2131 to make the spellchecker more accessible to more people!
Lastly, I am still confused about the LibreOffice dictionaries (not the custom dictionary for Splink). From what I can find online, aspell does not support .aff files, so I don't understand how that is working. And the LibreOffice dictionaries don't seem to be necessary: I now get
Spelling check passed :)
in the master branch, despite having commented out those lines of the script entirely.
Nice spot! I think these were legacy files from an earlier dev version and/or possibly replying in hunspell
instead. Thanks for removing them in your PR #2131
from splink.
Related Issues (20)
- Splink4 : cumulative_comparisons_to_be_scored_from_blocking_rules_chart does support salted or exploding BRs
- Splink4: `set_match_probability_to_one` can probably be removed from `block_using_rules_sqls` HOT 1
- Use with recursive for faster clustering HOT 3
- [FEAT] cluster_studio_dashboard - Option to display clusters grouped by dataset
- Evaluation from ground truth column does not work without blocking rules specified HOT 1
- Need to document `ColumnExpression`
- Replace settings dict guide with SettingsCreator reference HOT 1
- `count_num_comparisons_from_blocking_rule` missing from new Linker API HOT 1
- Some backends don't get completeness correct for array columns HOT 2
- Test chart data
- Better error for undialected ColumnExpression
- Completeness chart fails when data has `source_dataset` column
- [FEAT] Additional argument to filter comparisons shown in comparison viewer dashboard
- Splink 4.0.0: AttributeError: 'Linker' object has no attribute 'query_sql'
- Databricks custom SQL functions aren't registered
- Can't create SQLiteAPI with `register_udfs=False`
- Zero trained m-values can lead to `math domain error`
- `NaN` trained values can break `predict()` HOT 1
- Add option for Input Table with Athena Linker connection
- Splink install failing due to `splink_datasets` `PermissionError` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from splink.