molnarg/node-http2-protocol

WARNING: This code was merged into node-http2

node-http2-protocol's Issues

WINDOW_UPDATE frame with oversized payload or without payload should raise error of type FRAME_SIZE_ERROR

If a frame size exceeds any defined limit, or is too small to contain mandatory frame data, the endpoint MUST send a FRAME_SIZE_ERROR error (draft-09, section 4.2)

Compression: implement a real streaming decompressor

• that can be used to implement header buffer space limitation
• and can avoid costly buffer copies

Unknown frame types must be ignored

Implementations MUST ignore frames of unsupported or unrecognized types (draft-09, section 4.1). Now endpoint fails when receives incoming frame with unknown frame type in function readCommonHeader.

Update examples to use node-http2-protocol instead of node-http2

Flow control may block non-flow-controlled frames

For all frame types, lib/stream.js uses this._pushUpstream to submit the frame for sending, which in turn calls Flow.prototype.push. In Flow.prototype.push, we could conceivably get into a state where there are DATA frames queued (so this._queue.length !== 0), so moreNeeded will not get set to non-null, and the check on line 278 will evaluate to true, thus enqueuing the frame, regardless of what type of frame it is. We should check the frame type in Flow.prototype.push before checking moreNeeded at all, so we don't end up blocking non-flow-controlled frames (I think).

I can whip up a patch for this, but I wanted to submit the issue to make sure I'm not crazy before doing the work :)

Upgrade to the -07 draft

Sending frames on already closed stream should raise RST_STREAM

An endpoint MUST NOT send frames on a closed stream. An endpoint that receives any frame after receiving a RST_STREAM MUST treat that as a stream error of type STREAM_CLOSED instead of sending GOAWAY frame (draft-09, section 5.1)

Sending BLOCKED frame

Use simple-streams internally for data flow

Reserved bits are treated as part of frame length

A reserved 2-bit field. The semantics of these bits are undefined and the bits MUST remain unset when sending and MUST be ignored when receiving (draft-09, section 4.1)

PING frame with a length field value other than 8 must raise FRAME_SIZE_ERROR

Receipt of a PING frame with a length field value other than 8 MUST be treated as a connection error of type FRAME_SIZE_ERROR instead of PROTOCOL_ERROR (draft-09, section 6.7)

SETTINGS frame with ACK flag set and non-zero length

Receipt of a SETTINGS frame with the ACK flag set and a length field value other than 0 MUST be treated as a connection error of type FRAME_SIZE_ERROR (draft-09, section 6.5)

Forbid sending a promise when the peer disables it

header compression error

Recently we have built some HPACK test cases https://github.com/Jxck/hpack-test-case
I'd like to add node-http2 compressor to there. While doing that, I found a bug in HeaderTable.prototype._enforceLimit. The code you should look at is:

droppedEntries[droppedEntries] = dropped;

droppedEntries is an array and stores the dropped entries. But the above code sets itself as index, which is apparently a bug.

I suspect that it is dropPoint, but I leave the fix for you. (I'm not really Nodejs guy)

The failed testcase is https://github.com/Jxck/hpack-test-case/blob/master/nghttp2/story_20.json When encoded by node-http2 compressor, at case #37 (1-based), it emits 2 empty name/value pairs.