molpro/molpro-plugin

Host and guest code for Molpro plugin framework.

molpro-plugin's Issues

library cmake configuration - [merged]

In GitLab by @KnowlesPJ on Jul 7, 2019, 15:47

Merges master -> master

compilation failure with gfortran 10

In GitLab by @ajmay81 on Jun 16, 2020, 10:18

PluginGuestF.F90 fails to build with gfortran 10, one can either fix the code or build with new compiler option -fallow-argument-mismatch (as we do inside Molpro because of the huge number of historical mismatches):

_deps/_private_dep_molpro_plugin-src/lib/PluginGuestF.F90:122:34:

  115 |   IF (m_rank.EQ.0) CALL MPI_Send(length,1,MPI_INT,0,0,m_intercomm,ierr)
      |                                 2 
......
  122 |    IF (m_rank.EQ.0) CALL MPI_Send(TRIM(value),length,MPI_CHAR,0,1,m_intercomm,ierr)
      |                                  1
Error: Type mismatch between actual argument at (1) and actual argument at (2) (CHARACTER(66995424)/INTEGER(8)).
_deps/_private_dep_molpro_plugin-src/lib/PluginGuestF.F90:100:33:

  100 |   IF (m_rank.EQ.0) CALL MPI_Recv(PluginGuestF_receive,length,MPI_INT,0,1,m_intercomm,status,ierr)
      |                                 1
......
  117 |   IF (m_rank.EQ.0) CALL MPI_Recv(answer,1,MPI_INT,0,0,m_intercomm,status,ierr)
      |                                 2
Error: Type mismatch between actual argument at (1) and actual argument at (2) (CHARACTER(0)/INTEGER(8)).
_deps/_private_dep_molpro_plugin-src/lib/PluginGuestF.F90:101:17:

  101 |   CALL MPI_Bcast(PluginGuestF_receive,length,MPI_CHAR,0,m_world,ierr)
      |                 1
......
  114 |   CALL MPI_Bcast(length,1,MPI_INT,0,m_world,ierr)
      |                 2
Error: Type mismatch between actual argument at (1) and actual argument at (2) (CHARACTER(0)/INTEGER(8)).
_deps/_private_dep_molpro_plugin-src/lib/PluginGuestF.F90:41:17:

   41 |    CALL MPI_Recv(id,length,MPI_CHAR,0,1,m_intercomm,status,ierr)
      |                 1
......
  117 |   IF (m_rank.EQ.0) CALL MPI_Recv(answer,1,MPI_INT,0,0,m_intercomm,status,ierr)
      |                                 2
Error: Type mismatch between actual argument at (1) and actual argument at (2) (CHARACTER(1024)/INTEGER(8)).
_deps/_private_dep_molpro_plugin-src/lib/PluginGuestF.F90:77:17:

   77 |   CALL MPI_Bcast(m_host,length,MPI_CHAR,0,m_world,ierr)
      |                 1
......
  114 |   CALL MPI_Bcast(length,1,MPI_INT,0,m_world,ierr)
      |                 2
Error: Type mismatch between actual argument at (1) and actual argument at (2) (CHARACTER(0)/INTEGER(8)).
_deps/_private_dep_molpro_plugin-src/lib/PluginGuestF.F90:81:17:

   81 |   CALL MPI_Bcast(m_hostVersion,length,MPI_CHAR,0,m_world,ierr)
      |                 1
......
  114 |   CALL MPI_Bcast(length,1,MPI_INT,0,m_world,ierr)
      |                 2
Error: Type mismatch between actual argument at (1) and actual argument at (2) (CHARACTER(0)/INTEGER(8)).
_deps/_private_dep_molpro_plugin-src/lib/PluginGuestF.F90:82:17:

   82 |   CALL MPI_Bcast(m_active,1,MPI_LOGICAL,0,m_world,ierr)
      |                 1
......
  114 |   CALL MPI_Bcast(length,1,MPI_INT,0,m_world,ierr)
      |                 2
Error: Type mismatch between actual argument at (1) and actual argument at (2) (LOGICAL(8)/INTEGER(8)).

Adapt to gfortran-10 - [merged]

In GitLab by @KnowlesPJ on Jul 29, 2020, 16:04

Merges fix-1 -> master

LibraryManager layout adopted - [merged]

In GitLab by @KnowlesPJ on Sep 3, 2020, 17:02

Merges LibraryManager -> master

cmake: global SHA1 file, and add_subdirectory() only if first - [merged]

In GitLab by @KnowlesPJ on Jul 9, 2019, 18:06

Merges cmake -> master

Library manager - [merged]

In GitLab by @KnowlesPJ on Jun 8, 2020, 08:07

Merges LibraryManager -> LibraryManager

cmake - [merged]

In GitLab by @KnowlesPJ on Jul 4, 2019, 16:51

Merges master -> master

tidy - [merged]

In GitLab by @KnowlesPJ on Jun 8, 2020, 09:16

Merges LibraryManager -> LibraryManager

Cmake - [merged]

In GitLab by @KnowlesPJ on Jul 9, 2019, 15:58

Merges cmake -> master

Avoid dangling pointer in PluginGuestReceive - [opened]

In GitLab by @dkats on Oct 9, 2019, 13:41

Merges wildpointer -> master

Avoid dangling pointer in PluginGuestReceive - [closed]

In GitLab by @dkats on Oct 9, 2019, 13:36

Merges wildpointer -> master

std::string.c_str() is destroyed after leaving the PluginGuestReceive scope.