Giter Site home page Giter Site logo

Comments (7)

jzernisch avatar jzernisch commented on May 24, 2024

Yes, it seems like it interprets the first parameter as local time. For me (sitting in Germany), it is:

moment.tz("2013-11-18 11:55", "America/Toronto").format();
"2013-11-18T05:55:00-05:00"

But if I provide the ISO-formatted UTC time:

moment.tz("2013-11-18T11:55Z", "America/Toronto").format();
"2013-11-18T06:55:00-05:00"

I would also appreciate a more detailed documentation.

from moment-timezone.

kroo avatar kroo commented on May 24, 2024

This appears to be mostly correct in the latest release (0.0.3). Most timezones seem to behave consistently with documentation now, but I've run into a strange one:

// Reported examples now work as documented (from San Francisco, anyway)
> moment.tz("2013-11-18 11:55", "America/Toronto").format();
'2013-11-18T11:55:00-05:00'
> moment.tz(new Date(2013, 11, 18), "America/Toronto").format();
'2013-12-18T00:00:00-05:00'

// a few other examples
> moment.tz('2014-01-01', 'America/New_York').format()
'2014-01-01T00:00:00-05:00'
> moment.tz('2014-01-01', 'Europe/London').format()
'2014-01-01T00:00:00+00:00'
> moment.tz('2014-01-01 00:00:00', 'Europe/London').format()
'2014-01-01T00:00:00+00:00'

// However, London seems to be off by an hour, once, in 2012:
> moment.tz('2012-10-27', 'Europe/London').format()
'2012-10-27T00:00:00+01:00'
> moment.tz('2012-10-28', 'Europe/London').format()
'2012-10-28T01:00:00+01:00'
> moment.tz('2012-10-29', 'Europe/London').format()
'2012-10-29T00:00:00+00:00'

from moment-timezone.

jzernisch avatar jzernisch commented on May 24, 2024

The last one is just due to daylight saving time. Or what do you find strange here, @kroo?
EDIT: Sorry, misread your post. Yes the 2012-10-28 example is strange.

from moment-timezone.

tamzinblake avatar tamzinblake commented on May 24, 2024

Just as a side note, the moment-timezone website still seems to be using an older version, which really confused me trying to test in the console.

from moment-timezone.

timrwood avatar timrwood commented on May 24, 2024

This is fixed in #93.

from moment-timezone.

tamzinblake avatar tamzinblake commented on May 24, 2024

Nice! Thanks

from moment-timezone.

timrwood avatar timrwood commented on May 24, 2024

This is released in 0.1.0.

from moment-timezone.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.