moodle-an-hochschulen/moodle-block_cohortspecifichtml

This HTML block provides the possibility to selectively display the block to members of specific cohorts.

moodle-block_cohortspecifichtml's Issues

The block is not displaying in the dashboard !!

Hi,
I'm running Moodle 3.10 and want to try this plugin in order to give the students a dedicated links in their dashboard (I don't want this links to appear for other user types).

• I have a cohort All trainees with one user in it,

• I added a block in the default site dashboard and restricted it to the cohort mentioned,

• Logged in with the user in the cohort, but the block didn't appear!

Am I missing any options in this setup?!

Best regards,

Plugin files serving does not check the cohort membership

Do I read it right that the function block_cohortspecifichtml_pluginfile() does not check the user's cohort? I agree it is quite an edge case but ideally, it should respect the same access rules as the block_cohortspecifichtml::get_content().

Display Images

Hello

I use the Theme Lambda theme, and I have found that imported images will not show up in the block.

Can you assist please?

Regards
John

Global search support

In moodle/moodle@2f487b6#diff-79c157c869f23647543b6cb8f15388b8, global search support has been added to block_html which served as the boilerplace for this plugin.

It would be worthwhile to support global search in this plugin as well. The code from block_html can be used as boilerplate again in this case.

Bug in block_cohortspecifichtml_pluginfile() function

I think you may have an operator precedence issue in the function block_cohortspecifichtml_pluginfile() in lib.php. Instead of setting variable $file to a file object, lines 78-80 are setting variable $file to true:

if (!$file = $fs->get_file($context->id, 'block_cohortspecifichtml', 'content',
        0, $filepath, $filename) || $file->is_directory()) {
    send_file_not_found();
}

To address this issue, we have split the code as follows:

$file = $fs->get_file($context->id, 'block_cohortspecifichtml', 'content',
        0, $filepath, $filename);
if ( ($file === false) || ($file->is_directory() === true)) {
    send_file_not_found();
}

Hope this helps.

The 'Configuring the HTML (on cohorts) block with Javascript on' is broken on Moodle 3.9

On Moodle 3.9, a Behat scenario started to fail recently on Moodle 3.9:

001 Scenario: Configuring the HTML (on cohorts) block with Javascript on # /home/runner/work/moodle-block_cohortspecifichtml/moodle-block_cohortspecifichtml/moodle/blocks/cohortspecifichtml/tests/behat/block_cohortspecifichtml.feature:27
      And I add the "HTML (on cohorts)" block                            # /home/runner/work/moodle-block_cohortspecifichtml/moodle-block_cohortspecifichtml/moodle/blocks/cohortspecifichtml/tests/behat/block_cohortspecifichtml.feature:31
        Facebook\WebDriver\Exception\ElementNotInteractableException: element not interactable: element has zero size

The same scenario still works on Moodle 3.10 and 3.11.

SQL query composition

The SQL composed in block_cohortspecifichtml_cohorts_is_member() should be improved to

• Use placeholders (named or anonymous) instead of directly concatenating the SQL with incoming parameter. This is a good practise even when the parameters comes from safe sources like $USER->id or the block config.
• Make use of $DB->get_in_or_equal()

Transfer cohort functions to Moodle core

In locallib.php, there are some functions which are used to gather information about multiple cohorts at once.
It would be worthwhile to transfer these functions to Moodle core to /lib/cohortlib.php

Fix codechecker complaints about PHPUnit naming

Github actions started to complain recently about the naming of the existing PHPUnit tests:

FILE: ...odle-block_cohortspecifichtml/moodle-block_cohortspecifichtml/moodle/blocks/cohortspecifichtml/tests/privacy_provider_test.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 40 | WARNING | PHPUnit testcase name "block_cohortspecifichtml_privacy_testcase" does not match file name
    |         | "privacy_provider_test" (moodle.PHPUnit.TestCaseNames.NoMatch)
 40 | WARNING | PHUnit class "block_cohortspecifichtml_privacy_testcase" does not have any namespace. It is recommended to add it
    |         | to the "block_cohortspecifichtml" namespace, using more levels if needed, in order to match the code being
    |         | tested (moodle.PHPUnit.TestCaseNames.MissingNS)
------------------------------------------------------------------------------------------------------------------------------------

This originates to a change in local_codechecker which was integrated there in moodlehq/moodle-local_codechecker#161