mooreatv/bettervendorprice

Vendor price with stack information to make better decisions (WoW Classic, BC and Shadowlands)

bettervendorprice's Issues

Issue relay from CurseForge

User created an issue on the CurseForge issue tracker relating to latest version errors.

Link: https://www.curseforge.com/wow/addons/better-vendor-price/issues/5

I have also been seeing these errors, so +1.

Lua thrown error in classic wow: nil GetMouseFocus() {nothing under the mouse?}

Don't know if this gives you enough information.

Date: 2019-09-01 08:33:12
ID: 1
Error occured in: Global
Count: 1
Message: ...rface\AddOns\BetterVendorPrice\BetterVendorPrice.lua line 218:
nil GetMouseFocus()
Debug:
[C]: error()
...rface\AddOns\BetterVendorPrice\BetterVendorPrice.lua:218:
...rface\AddOns\BetterVendorPrice\BetterVendorPrice.lua:189
[C]: ?
[C]: OnTooltipSetItem()
Enchantrix\EnxMain.lua:232:
Enchantrix\EnxMain.lua:228
[C]: ?
...AddOns\Auc-Advanced\Libs\LibExtraTip\LibExtraTip.lua:408:
...AddOns\Auc-Advanced\Libs\LibExtraTip\LibExtraTip.lua:402
[C]: SetHyperlink()
...ce\AddOns\AutoBarClassic\AutoBarClassBasicButton.lua:77: TooltipShow()
...ce\AddOns\AutoBarClassic\AutoBarClassPopupButton.lua:62:
...ce\AddOns\AutoBarClassic\AutoBarClassPopupButton.lua:55
[C]: ?
..\FrameXML\SecureHandlers.lua:266:
..\FrameXML\SecureHandlers.lua:263
[C]: ?
..\FrameXML\SecureHandlers.lua:322:
..\FrameXML\SecureHandlers.lua:306
(tail call): ?
Locals:
(*temporary) = "nil GetMouseFocus()"

AddOns:
Swatter, v8.2.6377 (SwimmingSeadragon)
WowheadLooter, v11302
AdvancedInterfaceOptions, v1.3.2
ArkInventoryClassic, v10004
ArkInventoryClassicRules, v10000
ArkInventoryClassicSearch, v10000
AtlasLootClassic, vv1.1.8-beta
AucAdvanced, v8.2.6385 (SwimmingSeadragon)
AucFilterBasic, v8.2.6364 (SwimmingSeadragon)
AucScanData, v8.2.6365 (SwimmingSeadragon)
AucStatHistogram, v8.2.6366 (SwimmingSeadragon)
AucStatiLevel, v8.2.6370 (SwimmingSeadragon)
AucStatPurchased, v8.2.6367 (SwimmingSeadragon)
AucStatSimple, v8.2.6368 (SwimmingSeadragon)
AucStatStdDev, v8.2.6369 (SwimmingSeadragon)
AucUtilFixAH, v8.2.6371 (SwimmingSeadragon)
AutoBarClassic, v1.13.2.00
BeanCounter, v8.2.6381 (SwimmingSeadragon)
BetterVendorPrice, vv1.05.00-classic
DBMCore, v1.13.5
DBMDefaultSkin, v
DBMStatusBarTimers, v
DejaClassicStats, v1302r012
Details, v
DetailsTinyThreat, v
Dominos, v8.2.16
DominosCast, v
DominosEncounter, v
DominosProgress, v
DominosRoll, v
DugisGuideViewerZ, v1.012
Enchantrix, v8.2.6392 (SwimmingSeadragon)
InFlightLoad, v1.13.002
Informant, v8.2.6374 (SwimmingSeadragon)
LunaUnitFrames, v1.0
MonkeyBuddy, v
MonkeyLibrary, v
MonkeyQuest, v
MonkeyQuestLog, v
OmniCC, v8.1.1
Peggle, v2.2.3
Prat30, v3.2.31
Prat30Libraries, v
Questie, v4.0.13 BETA
RealMobHealth, v2.3
SexyMap, vv2-classic
Stubby, v8.2.6376 (SwimmingSeadragon)
TitanClassic, v1.0.5.11302
TitanClassicAmmo, v1.0.5.11302
TitanClassicBag, v1.0.5.11302
TitanClassicClock, v1.0.5.11302
TitanClassicGold, v1.0.5.11302
TitanClassicLocation, v1.0.5.11302
TitanClassicLootType, v1.0.5.11302
TitanClassicPerformance, v1.0.5.11302
TitanClassicRepair, v1.0.5.11302
TitanClassicVolume, v1.0.5.11302
TitanClassicXP, v1.0.5.11302
TomTom, vv11302-1.0.7
tullaRange, v8.2.2
WeakAuras, v2.14.6
WeaponSwingTimer, v4.0.2
WhatsTraining, v1.6
BlizRuntimeLib_enUS v1.13.2.11302
(ck=79e)

Tooltip-Issue since 10.0.2

Since patch 10.0.2 from 16.11 the AddOn throws an error. The exact error message is attached to the ticket.
The problem can be solved by removing line 302 and 303 in the BetterVendorPrice.lua file and replacing them with the following:

TooltipDataProcessor.AddTooltipPostCall(Enum.TooltipDataType.Item, BVP.ToolTipHook)

1x ...rface/AddOns/BetterVendorPrice/BetterVendorPrice.lua:303: GameTooltip doesn't have a "OnTooltipSetItem" script
[string "=[C]"]: in function `HookScript'
[string "@Interface/AddOns/BetterVendorPrice/BetterVendorPrice.lua"]:303: in main chunk

Locals:
(*temporary) = GameTooltip {
 0 = <userdata>
 SetQuestLogRewardSpell = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetQuestPartyProgress = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 ProcessLineData = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:303
 SetPvpTalent = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetRuneforgeResultItem = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetHyperlink = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetUnit = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetAzeriteEssence = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetVoidDepositItem = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetVoidWithdrawalItem = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetInfoBackdropStyle = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:338
 shoppingTooltips = <table> {
 }
 SetSocketGem = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 updateTooltipTimer = 0.200000
 ItemTooltip = Frame {
 }
 StatusBar = GameTooltipStatusBar {
 }
 SetLootCurrency = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetSlottedKeystone = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetWorldCursor = <function> defined @Interface/FrameXML/GameTooltip.lua:952
 SetLootItem = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetMerchantCostItem = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 GetUnit = <function> defined @Interface/FrameXML/GameTooltip.lua:994
 SetOwnedItemByID = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetItemInteractionItem = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetQuestLogSpecialItem = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 TextRight1 = GameTooltipTextRight1 {
 }
 SetEnhancedConduit = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetRecipeReagentItem = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetQuestCurrency = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 supportsDataRefresh = true
 SetWeeklyReward = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetMerchantItem = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetPvpBrawl = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetAchievementByID = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 BottomOverlay = Texture {
 }
 SetSpellByID = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 supportsItemComparison = true
 SetSocketedRelic = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 ProcessInfo = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:236
 ProcessLines = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:293
 NineSlice = Frame {
 }
 SetInventoryItem = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 RefreshData = <function> defined @Interface/FrameXML/GameTooltip.lua:933
 SetTransmogrifyItem = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetLootRollItem = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 OnLoad = <function> defined @Interface/FrameXML/GameTooltip.lua:927
 SetQuestLogCurrency = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetUnitDebuffByAuraInstanceID = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 SetBagItem = <function> defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444
 GetSpell = <function> defined @Interfa

rounding error bug

possible additional features

Maybe make a separate AH addon or add

• SortAuctionItems("list", "buyout")
  to sort by buyout instead of bid

• some option maybe for the order of the vendor price

• some option to hide the vendor price in bfa (not that items needing repair have a different price, at least in classic, basically the difference between repair cost and sell price)

full fledged api QueryAuctionItems

• dump all QueryAuctionItems("",nil,nil,0,0,0,true)
  (if canQuery,canQueryAll = CanSendAuctionQuery() is true; then batch,count = GetNumAuctionItems("list") then GetAuctionItemLink and/or? GetAuctionItemInfo)

Text stacked ontop of other text in tooltip

The text get stacked on top of the text from Reputable addon, is there a way to move the text downwards to avoid this?

Holding Ping causes LUA error

I mapped the Ping command to mouse5, and when i hold it to get the choice wheel, I get a Lua error from this plugin.

Here's the fix I've applied locally:

BetterVendorPrice/BetterVendorPrice.lua line 248:

if c then

change to

if c and c["GetName"] then

Hope some find that useful!
Cheers!

If it helps, I can put that into a Pull Request, but I think the change is small enough this might be enough to get it in?

double display for recipes

lua error on mission reward mouse over

2x ...rfaceBetterVendorPrice\BetterVendorPrice-@[email protected]:231: attempt to concatenate a nil value
...rfaceBetterVendorPrice\BetterVendorPrice-@[email protected]:231: in function <...rfaceBetterVendorPrice\BetterVendorPrice.lua:212>
[C]: ?
[C]: in function SetItemByID' ...s\Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua:1018: in function GarrisonMissionButtonRewards_OnEnter'
[string ":OnEnter"]:1: in function <[string ":OnEnter"]:1>

Locals:
t = GameTooltip {
0 =
updateTooltip = 0.167000
hasMoney = 1
comparing = false
shownMoneyFrames = 1
shoppingTooltips =

{
}
TopOverlay = {
}
ItemTooltip = {
}
SetHyperlink = defined =[C]:-1
needsReset = true
BottomOverlay = {
}
numMoneyFrames = 1
}
name = "S.P.A.R.E. Crate"
link = "|cff0070dd|Hitem:169610::::::::120:266::::::|h[S.P.A.R.E. Crate]|h|r"
_ = "S.P.A.R.E. Crate"
_ = "|cff0070dd|Hitem:169610::::::::120:266::::::|h[S.P.A.R.E. Crate]|h|r"
_ = 3
_ = 1
_ = 0
_ = "Miscellaneous"
_ = "Other"
itemStackCount = 250
_ = ""
_ = 986485
itemSellPrice = 1
c = {
0 =
IconOverlay = {
}
currencyQuantity = 125
Quantity = {
}
title = "Currency Reward"
IconBorder = {
}
Icon = {
}
itemID = 169610
}
(*temporary) = nil
(*temporary) = "Count"
(*temporary) = nil
(*temporary) = "Mouse focus is on % % % %"
(*temporary) = nil
(*temporary) = "Frame"
(*temporary) = nil
(*temporary) = nil
(*temporary) = {
WatchedTable = defined @BetterVendorPrice\MoLib/MoLib.lua:738
VerifySecureMessage = defined @BetterVendorPrice\MoLib/MoLib.lua:505
initNotDone = 1
debugPrint = defined @BetterVendorPrice\MoLib/MoLib.lua:145
DisplayInfo = defined @BetterVendorPrice\MoLib/MoLibUI.lua:737
EventHdlrs = {
}
format = defined @BetterVendorPrice\MoLib/MoLib.lua:106
InitRealms = defined @BetterVendorPrice\MoLib/MoLib.lua:205
PrintDefault = defined @BetterVendorPrice\MoLib/MoLib.lua:179
Warning = defined @BetterVendorPrice\MoLib/MoLib.lua:161
secureFutureThreshold = -5
GetRealmByID = defined @BetterVendorPrice\MoLib/MoLib.lua:233
securePastThreshold = 45
PrintInfo = defined @BetterVendorPrice\MoLib/MoLib.lua:184
Frame = defined @BetterVendorPrice\MoLib/MoLibUI.lua:72
rest = defined @BetterVendorPrice\MoLib/MoLib.lua:353
ToHex = defined @BetterVendorPrice\MoLib/MoLib.lua:420
DrawPixel = defined @BetterVendorPrice\MoLib/MoLibUI.lua:774
SplitFullName = defined @BetterVendorPrice\MoLib/MoLib.lua:373
extractRealmID = defined @BetterVendorPrice\MoLib/MoLib.lua:265
GetMyRegion = defined @BetterVendorPrice\MoLib/MoLib.lua:221
CloneTable = defined @BetterVendorPrice\MoLib/MoLib.lua:47
AddHashKey = defined @BetterVendorPrice\MoLib/MoLib.lua:454
optionsPanel = {
}
EscNonPrintableAndPipe = defined @BetterVendorPrice\MoLib/MoLib.lua:89
addonVersion = "vX.YY.ZZ"
gold = {
}
SavePosition = defined @BetterVendorPrice\MoLib/MoLibUI.lua:1054
ToolTipHook = defined @BetterVendorPrice\BetterVendorPrice.lua:212
GetMyFQN = defined @BetterVendorPrice\MoLib/MoLib.lua:382
RandomId = defined @BetterVendorPrice\MoLib/MoLib.lua:403
Map = defined @BetterVendorPrice\MoLib/MoLib.lua:362
Slash = defined @BetterVendorPrice\BetterVendorPrice.lua:86
ChangeScale = defined @BetterVendorPrice\MoLib/MoLibUI.lua:659
UnHash = defined @BetterVendorPrice\MoLib/MoLib.lua:462
MoLibInstallInto = defined @BetterVendorPrice\MoLib/MoLib.lua:59
DebugStack = defined @BetterVendorPrice\MoLib/MoLib.lua:165
measure = defined @BetterVendorPrice\MoLib/MoLib.lua:790
CreateOptionsPanel = defined @BetterVendorPrice\BetterVendorPr