mootikins/rust-matrix-project

rust-matrix-project's Issues

[Feature] Non-consuming scalar multiplication

There are impl Mul<i32> for Matrix and impl Mul<Matrix> for i32 which forwards to first impl. These methods take Matrix by value. However, implementations of these methods requires only reference to Matrix, so it should be possible to write impl<'a> Mul<i32> for &'a Matrix and impl<'a> Mul<&'a Matrix> for i32 respectively.

[Feature] Inplace operations

This repo has implementations for addition and subtraction of matrices. However, all of them produce fresh new Matrix even if we don't need operands afterwards. In order to have a way to reduce allocations, one should have way to reuses allocated memory and operate on it.

Consider switching matrix storage to Box<[i32]>

Matrix requires owned dynamically sized storage. However, so far no matrix methods used Vec's ability to dynamically change size. If you have no plans to add such methods in future, consider switching storing data to boxed slice. Compared to Vec, it doesn't have methods to change it's size (which can prevent some errors) and it doesn't store additional usize for capacity.

Panics are not documented

Matrix operations all have assert!s which are not documented, meaning it can cause unexpected panics for users of the library. Rust API guidelines says that panics should be properly documented.