moreonion/campaignion

The campaignion drupal module.

Campaignion

This project contains the main functionality of campaignion a distrubution and SaaS for online campaigning and online fundraising.

Browser compatibility

JavaScript in this project is transpiled for IE 11 and Edge 18 compatibility. It does however not include the necessary polyfills. Adding these is left as responsibility of the distribution.

We recommend using polyfill.io or something similar, for example by adding this in your profile’s hook_init()-implementation:

if ($polyfill_url = variable_get('polyfill_url', 'https://polyfill.io/v3/polyfill.min.js?flags=gated')) {
  drupal_add_js($polyfill_url, [
    'type' => 'external',
    'group' => JS_LIBRARY,
    'every_page' => TRUE,
    'weight' => -50,
  ]);
}

campaignion's Issues

[GA Module] Session/Localstorage not available breaking the entire site

Prior to Safari 11 (iPads and iPhones with old iOS running) in private mode they restrict access to Local and Sessionstorage, this means each accessing these methods throws an error on Safari 10 and below and the website is unusable.

We detected some uncatched errors on these lines:
https://github.com/moreonion/campaignion/blob/7.x-1.x/campaignion_google_analytics/tracking.js#L493
https://github.com/moreonion/campaignion/blob/7.x-1.x/campaignion_google_analytics/tracking.js#L510

Potentially also the get methods are affected on that.

Do not try to import when submission is still draft

the cron jobs currently try to import new submissions into Redhen even if they are not completed yet, thus triggering Drupal\campaignion\NoEmailException errors in src/Contact.php (fromEmail()).

[Camp_GA] JS issue when cookies are disabled

Viewed on: 2018-03-27
URL to reproduce: https://secure.mencap.org.uk
Browser: Chrom(ium) 64 on Linux, Cookies DISABLED

Inspector error:

Uncaught DOMException: Failed to read the 'sessionStorage' property from 'Window': Access is denied for this document.
at Object.Drupal.behaviors.campaignion_google_analytics_donation.attach

Related JS code, in particular:

if (typeof window.sessionStorage === 'undefined') {
        window.sessionStorage = {};
        window.sessionStorage['setItem'] = function () {};
        window.sessionStorage['getItem'] = function () {};
        window.sessionStorage['removeItem'] = function () {};
      }

window.sessionStorage cannot be read => JS error ==> page looks weird

moreonion/morelesszen#1 might be a related issue

newsletters: No handling for deleted lists.

If a newsletter list is deleted on the provider side this deletion is not synced to campaignion. Campaignion then still allows subscribes to that list and tries to update list members leading to indefinitely failing API calls in the queue.

[campaignion_newsletters_mailchimp] merge fields don't accept boolean

Mailchimp does not accept boolean values for merge fields and responds with a 400 error. If a merge field is "true", we need to send "1" instead.

[campaignion_newsletters] variable info

The campaignion_newsletters and campaignion_newsletters_optivo modules are implementing hook_variable_info(). For consistency, hook_variable_info() should be added to the other newsletters submodules as well. Then the default values for variable_get() are no longer needed and can be removed.

(see #40 (review))

[email_to_target] Hawk authentication to e2t service fails with unicode characters

When the URL-path contains 2-byte UTF-8 characters the HAWK authentication fails. It seems the e2t service and campaignion don’t hash the same data in this case.