moreonion/drupy

Drupal site-builder based on JSON-recipes

drupy's Issues

File permissions when extracting archives

Currently setuptools.archive_util.unpack_archive is used to unpack downloaded zip-files and tar-files as a simple function that handles both cases using Python’s built-in functions. When unpacking it sets the owner and permission of the extracted files to those specified in the archive, which is not always what we want when distributing code (eg. ckeditor-4.16.1 doesn’t grant read permissions for anything but the owner). There is two possible solutions:

1. Find an alternative wrapper that allows us to specify that we don’t want to keep the permissions from the archive.
2. Correct the permissions afterwards.

As there doesn’t seem to be an alternative capable of 1. I tend towards 2.

ruamel.yaml > 0.15.51 breaks setup parsing

If ruamel.yaml > 0.15.51 is installed, parsing of setup files fails with: TypeError: Object of type 'CommentedMap' is not JSON serializable.

Steps to reproduce:

1. pip3 install drupy
2. pip3 install --upgrade ruamel.yaml
3. drupy install mysetup

This fails with all .yaml files, no matter if they're valid or not (even empty .yaml files produce the error).

Workaround:
pip3 install ruamel.yaml==0.15.51