morepath/more.transaction

transaction integration for Morepath

Morepath: Python web microframework with super powers

Morepath is a Python web framework. An application consists of models. Each type of model is published on a URL path. Content is exposed to the web using views.

Documentation.

more.transaction's Issues

Raises unicode error with transaction 2.0

When more.transaction is used with transaction 2.0 the following type error appears:

env/local/lib/python2.7/site-packages/more/transaction/main.py:64: in transaction_tween
    t.note(request.path)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <transaction._transaction.Transaction object at 0x7f1651c780d0>, text = '/'

    def note(self, text):
        """ See ITransaction.
            """

        if not isinstance(text, text_type):
>           raise TypeError("Note must be text (unicode)")
E           TypeError: Note must be text (unicode)

env/local/lib/python2.7/site-packages/transaction/_transaction.py:537: TypeError

This happens because in Transaction 2.0.3

The user and description fields must now be set with text (unicode) data. Previously, if bytes were provided, they’d be decoded as ASCII.

uppercase version of transaction app

Right now we export transactionapp, lowercase. Provide an uppercase TransactionApp too, and just alias the transactionapp for compatibility.

userid not taken properly

The code has some XXX marked that it should get the userid somehow from the identity on the request. Currently this is not happening, so the info is not properly recorded in the transaction.

Fail with Morepath 0.15 and multiple attempts

Using multiple attempts (> 1) and Morepath 0.15 (unreleased) results in lots of 404s because the paths cannot be resolved correctly anymore.

This is du to the change of the unconsumed path order with Morepath 0.15:
morepath/morepath@e2c7c42

This conflicts with https://github.com/morepath/more.transaction/blob/fe275f0/more/transaction/main.py#L64

Ideally we make sure that there's some kind of public api for this in morepath, so we don't have to keep those implementations in lockstep.

reraise is complicated

There's complicated logic to implement a reraise functionality, different in Python 2 and 3. I am wondering why this is not simply implemented with raise (without arguments). Perhaps this has to do with some kind of traceback manipulation I don't quite understand.

Note also that the PY3 compat layer defines an exec_ function that doesn't appear to be used.

If we can get rid of the complexity that would be nice -- running exec and frame manipulation is pretty extreme.

Release 0.2 is incompatible with morepath 0.7

These lines in main.py will fail:

attempts = app.settings.transaction.attempts
commit_veto = app.settings.transaction.commit_veto

I tried out morepath 0.7 pretty quickly ;)

Update supported Python versions

• drop support for Python versions < 3.6
• add support for Python versions 3.7, 3.8 (if missing)
• fix linting errors (if present)

If you are a beginner, and need to help for this issue, especially during Hacktoberfest, please comment here or reach out to me via https://jugmac00.github.io/

When using more than one variable in the path, the retried request fails

If a path like /page/{type}/{id} is retried using more.transaction, the request is no longer correctly parsed and the wrong view is found. /page/{type} works fine.

The fix seems rather simple. We need to reset the request correctly when attempting a new request:

if attempts != 1:
    request.make_body_seekable()
    request.unconsumed = parse_path(request.path_info)

(note the request.unconsumed line)

I'll write a test and a bugfix.