Giter Site home page Giter Site logo

Comments (3)

zq1997 avatar zq1997 commented on June 9, 2024

I debugged it out.
The reason is that I install socketIO-client from pip, so it is the newest version 0.7.2
But This project only works with 0.5.7.2

Thus this code failed to construct a SocketIO instance.

# olclient.py:154
        socket_io = SocketIO(
            BASE_URL,
            params={'t': int(time.time())},
            headers={'Cookie': cookie}
        )

Maybe some modification should be made to work with newer socketIO-client version.
Further more, how about drop the usage of SocketIO ? I found socketIO-client is only used in this code, and I remember that pure Python can also do socket communication, drop socketIO-client and use standard python lib may cause less dependency problem.

Also, when I pip install this project, it not install socketIO-client automatically as an dependecy. Is this a bug?

from overleaf-sync.

moritzgloeckl avatar moritzgloeckl commented on June 9, 2024

Hi @zq1997 !

Thank you for your bug report. Let me clarify:

  • Yes this is a bug I need to add the socketIO-client dependency so it will be installed via pip. Working on this now.
  • It needs this specific version because Overleaf is working with an "outdated" Socket.IO version. This is the last version of the Python library to support the version their using.
  • You surely can implement it without the socketIO client, but beware that we're talking about Socket.IO Protocol and not just simple Sockets or Websocket. I found it easier to use the library then to implement the Socket.IO handshake myself. Feel free to open a PR though.

from overleaf-sync.

moritzgloeckl avatar moritzgloeckl commented on June 9, 2024

Fixed with #12

from overleaf-sync.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.