Giter Site home page Giter Site logo

Add description feature flaw? about pe HOT 1 OPEN

MorningLit avatar MorningLit commented on August 30, 2024
Add description feature flaw?

from pe.

Comments (1)

nus-se-bot avatar nus-se-bot commented on August 30, 2024

Team's Response

We wanted to be uniform in our architecture when implementing our commands, this is so that we can maintain extensibility for our description commands.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: Sorry, but I have to disagree. I am arguing from a fast typist point of view and I believe that these unnecessary prefixes if they could be removed, should be removed.
From my understanding of prefixes, the main reason why prefixes are used originally in the addressbook, was because the user had to type in long verbose commands of each type, and the prefixes exist to allow users to be flexible when inputting their long commands (such as add case t:hello s:active is equivalent to add case s:active t:hello).
However, for this situation, there is clearly no flexibility here. Thus, they should be removed for the sake of fast typists.
Not to mention but your entire project failed to account for users who are fast typists and there was no optimisation put in place for these users (some suggestions could be allowing prefixes of commands to be executed, eg. add c t:hello is equivalent to add case t:hello or the implementation of supporting smart-tab, where the users can type in the prefix of a command and then press tab, and the app would fill in the rest of the word with a valid command for the user)
I am also unsure what you meant by "maintain extensibility for our description commands." because, from my understanding, this is all handled by the individual distinct parser, not the individual commands.
Overall, after much reconsideration, I feel that this issue should be raised to a low or medium severity level, because it can cause much inconvenience to fast typists.


from pe.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.