morninglit/pe

pe's Issues

Incorrect response from result display?

The title updated in index 1 does not correspond with the title in the result display

Invalid phone numbers can be added

Invalid phone numbers can be added and I think checking of valid phone numbers can be done easily (checking whether the first digit is a 6/8/9, then checking the length of the phone number to be exactly 8, special phone numbers can be added too)

Very small inconsistency issue

Not sure if this is worth mentioning but its slightly bothering my OCD, because for the sex prefix, "s" could be used instead of "sex" and remain consistent with the other prefixes.

Activity Diagram can be improved?

For now its just showing the MSS, maybe consider scenarios where user input is not valid?

Add description to current case documentation bug?

I do not know whether if this is intended or not, but there is an invisible hover link in the box shown, not sure if this appears only on my side also.

Similarly for this too

Besides that, I think the proper sentence should be "You cannot add a description of a case that already has a description using this command." instead of
"You cannot edit a description of a case that already has a description using this command."

Some DG links are not updated

Logic.java and LogicManager.java does not have their respective links.

This Logic.java link brings me to addressbook's Logic.java page.

Very minor inconsistency issue in DG

Not sure if this is worth mentioning but, the enumeration for Sex is not shown even though the other enumerations(ArchiveStatus and Status) are shown.

UML diagram self invocation method displayed incorrectly?

There is suppose to be a small box to illustrate self invocation methods (updateCaseInformationPanel(Index))

Outdated picture and description in DG

Pretty sure there is no saveAddressBook command in your project and there is definitely no "delete 1" command .

Inconsistent DG use case error handling

For this, when there is an invalid input, the use case ends. The use case should resume at step 2.

However, for this, when there is an invalid input, the use case resumes at step 3.

Add description feature flaw?

I'm not sure why its needed for the prefix "d:" here because it only accepts in one input from the user, it can cause minor inconvenience for long term or experienced users.
This can be applied to edit title, edit desc, edit status as well

UML diagram undefined return type?

"d" and "result" are not defined when returning

Repeated content

Not sure why there is a need to repeat the specification of a person again when its already mentioned for the adding of person command

Interface not explicitly declared in UML diagram

UserPrefs is shown to implement ReadOnlyUserPrefs but ReadOnlyUserPrefs is not shown to be an interface.