mosheberman/koshercocoa-legacy

A port of the KosherJava project from Java to Objective-C Cocoa

koshercocoa-legacy's Issues

github repo is displayed as Java repository

wow. great framework! I was playing with it a little.

it's a little confusing that this repo is displayed as Java repo in the search results and github's index pages. you might want to remove those java files.

you can see it in here for example: https://github.com/MosheBerman

NSObjCRuntime.h and other errors!

Sorry for bothering, but I am a newbie!
I am having an issue using this useful project. I am following Wiki:

1. Added "Required" and "Times" folders in my project (taken from "KosherCocoa) : OK
2. Imported in my *.m file :

import "GeoLocation.h"

import "AstronomicalCalendar.h"

3. I Created a GeoLocation and set "Latitude" and "Longitude" in it
   (I took those data from currentLocation.coordinate.latitude and currentLocation.coordinate.longitude)

4. Next, I create AstronomicalCalendar, but I get this error:

No visible @interface for /Users/ciavanni/Desktop/Ciavapps/iGiorniContati/sole.m:124:81: No visible @interface for 'AstronomicalCalendar' declares the selector 'initWithGeoLocation:'

and if I try to compile there are a lot of issues with NSObjCRuntime.h

Do I have any chances to make it work for my "app" ? :-)

Thanks for helping me!

Faulty adjustment of Sunset

Sunset times can be offset by an extra 24 hours as is. A fix is on the way.

leap year computation in SefiraDay.m is not needed

the following code is not necessary:

//If it's a leap year, push off sefira for a month
if ([self isHebrewLeapYear:year]) {
    [hebrewComponents setMonth:8];
}else {
    [hebrewComponents setMonth:7];
}

The NSHebrewCalendar doesn't change indices for months other than Adar I and Adar II as described here:

http://stackoverflow.com/questions/8198526/do-i-understand-nshebrewcalendar-correctly

As implemented, your first day of the omer will be off by a month on hebrew calendar leap years.