mozilla-mobile/firefox-ios

Firefox for iOS

firefox-ios's Issues

Missing argument for parameter rootPath in call

When I try to build the Client an error Missing argument for parameter 'rootPath' in call is throw in some of the files
firefox-ios/StorageTests/SQLiteRemoteClientsAndTabsTests.swift
firefox-ios/StorageTests/TestTableTable.swift etc.

I think the problem is when MockFiles is instantiated it requires a rootPath parameter which is not being passed currently. MockFiles inherits from FileAccessor whose initializer takes rootPath as parameter.

Recommendation: Add Handoff Support for Firefox on OSX and the iOS App

It would be nice if Firefox could hand-off your tabs from your mac to your iPhone and vice versa. Other browsers have this feature and it would be nice for Firefox to have as well.

Device name style in synced tabs should not appear to be tappable

The style of the device name is black and appears as clickable as the tabs beneath it. It should be styled differently as it's only a label, and the user cannot collapse the device. Gray perhaps @darrinhenein?

Save password dialog copy changes

Currently in iOS Firefox:

CURRENT:

• "Do you want to save the password for [email protected] on domain.org?"
• Yes
• Not now

PROPOSED

• "Save this login for domain.org?"
• Save Login
• Don’t Save

We are moving to a new design in desktop, although not as quickly as you are able to in mobile. It is not recommended to copy it completely (as the UI is more complex), but the copy should be enough

Details:
https://mozilla.invisionapp.com/share/PC3Y0QSRK#/screens/96290118

Fennec currrently does, which we will change to "save":

• "Would you like to remember this login?"
• [email protected] (clickable to edit dialog)
• Remember
• Never

1Password extension not available in Firefox app

In most other applications the 1Password extension is available to fill in usernames and passwords securely, for some reason it is not available in the Firefox app.

I have checked in the '...' to ensure it isn't simply disabled.

On iPad, Firefox Sync login screen have scroll in it. I think it should be hidden to make it looks like native screen

Note: I'm using iPad mini 2 (retina) with iOS 9.0.2.

iPad crashes when opening firefox

When i try to open firefox on my ipad it crashes.

Add download support

Yes for download from site as pcworld.com,chip.de,uploaded.to,mediafire etc....
E.g Icab mobile browser,Apple Safari iOS, Download HD lite. This can this features.
Please test it. And add this for Firefox iOS.

Question on same-origin policy (SOP) across iframes

Does firefox-ios's webkit implementation allow access to web preferences so that one can disable SOP across iframes that have different origins? Or is it just a view controller (or some kind of wrapper) built over the standard iOS Webkit library?

String freeze

As we get closer to shipping, we're planning to freeze all strings in the product, including a11y strings. The string freeze allows us to dispatch all strings in the product to people that can translate across different language by the time we launch v1.

@dusek, what's your opinion on the status of a11y right now? Are there any labels/hints that still need to be updated? It sounds like we want to do the string freeze very soon, so consider any such changes high priority if you're planning on taking them. Sorry for the short notice!

[deleted]

Missing words in string? Clear private data.

When translating Firefox for iOS i found an english string that I think are missing a couple of words.
In the file: Client/Frontend/Settings/SettingsTableViewController.swift line 384
The line reads:

var message: String { return NSLocalizedString("Are you sure you want all of your data? This will also close all open tabs.", tableName: "ClearPrivateData", comment: "Message shown in the dialog when clearing everything")

Shouldn't it read "Are you sure you want to clear all of your data? […]"?

Test on Device

I've signed iOS device for testing, when I try to run firefox from iOS simulator, it works perfectly. But when I want to test on device, I shows signing error.

Check dependencies

** Code Sign error: No matching provisioning profiles found: None of the valid provisioning profiles allowed the specified entitlements: com.apple.security.application-groups, keychain-access-groups.
Warning: The Copy Bundle Resources build phase contains this target's Info.plist file '/Users/rahmanmdrezaur/code/firefox-ios/Extensions/ViewLater/Info.plist'.
CodeSign error: code signing is required for product type 'App Extension' in SDK 'iOS 8.4'

No matching provisioning profiles found: None of the valid provisioning profiles allowed the specified entitlements: com.apple.security.application-groups, keychain-access-groups.

CodeSign error: code signing is required for product type 'App Extension' in SDK 'iOS 8.4' **

Build fails because of Storage framework

When I try to build the project, I get this error:

ld: framework not found Storage for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Framework not found Storage for architecture arm64

On iPad, Firefox Sync login screen have scroll in it. I think it should be hidden to make it looks like native screen

Wrong repo, sorry!

[Feature] Find in Page

Don't see Find Text in Page implemented in the currently released version.

Add support for gamepad

How about adding support for the Gamepad API?

It looks as simple as injecting navigator.getGamepads and forwarding events to the UA.
See https://developer.mozilla.org/en-US/docs/Web/Guide/API/Gamepad

Project does not build

I get compiler errors (missing file) when trying to build the project for a real device:

clang: error: no such file or directory: '/Users/antoniogermano/Work/Mobile/firefox-ios/ThirdParty/sqlcipher/sqlite3.c'
clang: error: no input files

I have tried to build it exactly as said on the GitHub page, and I'm building using Xcode.

If I try to run on the simulator instead I get a very similar error, just using another location:

module sqlite3 [system] {
    // the line below causes the error
    header "/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS8.3.sdk/usr/include/sqlite3.h"
    link "sqlite3"
    export *
}

/Users/antoniogermano/Work/Mobile/firefox-ios/Storage/modules/module.modulemap:2:12: error: header '/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS8.3.sdk/usr/include/sqlite3.h' not found
header "/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS8.3.sdk/usr/include/sqlite3.h"
       ^
<unknown>:0: error: could not build Objective-C module 'sqlite3'

Did anybody else have this problem?

(Bounty) Allow usage of own Firefox Sync token server

We use an own Firefox Sync server like described in https://docs.services.mozilla.com/howtos/run-sync-1.5.html. But there is no way to configure the Firefox Sync token server URL to point to our own sync server other than modifying the source code in Account/FirefoxAccountConfiguration.swift, line 111.

Can we add an option for that? Should I do a PR?

Reduce Sync size in Settings

A friendly suggestion from the Sync team. @darrinhenein thoughts?

Make it a Universal App

I am wondering why the existing client is just iPhone only? I think we can easily change it to a universal app using Autolayouts?

Xcode 7, building...

So, I'm a beta tester for OSX 10.11 and iOS 9.0, and I was interested in this project and decided to build it. I've got an iPad Mini (1st Gen, armv7, running iOS 9, like I said) and an iMac Mid 2011-ish or something (running OSX 10.11) and Xcode 6.4 is no longer supported on OSX 10.11, so I downloaded the Xcode 7 beta, but I can't get firefox-ios to build. I've installed Carthage, and I ran sh ./checkout.sh, so it's not that (I think). First of all, I get lots of Linker command failed with exit code 1 errors:

For Account:
ld: file not found: /Users/.../Library/Developer/Xcode/DerivedData/Client-bzciiebpmlbacuafrxtvtaueubcl/Build/Intermediates/SwiftMigration/Client/Intermediates/Client.build/Debug-iphoneos/Account.build/Objects-normal/armv7/FirefoxAccountConfiguration.o
clang: error: linker command failed with exit code 1 (use -v to see invocation)

For XCLogger:
ld: file not found: /Users/.../Library/Developer/Xcode/DerivedData/Client-bzciiebpmlbacuafrxtvtaueubcl/Build/Intermediates/SwiftMigration/Client/Intermediates/XCGLogger.build/Debug-iphoneos/XCGLogger (iOS).build/Objects-normal/armv7/XCGLogger.o
clang: error: linker command failed with exit code 1 (use -v to see invocation)

And on, and on...

And it doesn't fail on these errors, nope. It keeps going on and hangs on the build for Storage at Compiling Swift source files.

I even get lots of nice little yellow warnings telling me that Call to an error throwing function cannot be converted!

Any ideas/help? It is a problem you're going to have to solve, because eventually iOS 9 will become a release and so will OSX El Capitan.

How-to build in my device?

I tried to compile the application directly into a device (iPhone 5) and I failed, I mark error when trying to sign the application, as it could run it on my device?

Error when run checkout.sh

It is fatal with "Refusing to fetch into current branch refs/heads/master of non-bare repository" when run sh ./checkout.sh

Stock bookmarks can't be removed

There are two 'stock' bookmarks that can't be removed, this is annoying:

Compilation hangs on BrowserTable.swift (llvm bug)

You broke swift! Certainly llvm's fault, but mentioning it in case it can be worked around.
Or perhaps, there is a different version of llvm that can be suggested for use.

$ llvm-gcc -v
Apple LLVM version 7.0.0 (clang-700.1.76)
Target: x86_64-apple-darwin14.5.0
Thread model: posix

Provide documentation for setting up entitlements

I'd love to help out on this project, but it would be nice to have some documentation on how to set up the entitlements/certificates correctly so that I can build it on my own.

Firefox using signficant energy

Hi,

Unlikely I am not a contributor to firefox, but I have noticed an issue that made me feel really sad and that's why I am posting here.

Firefox app uses so much CPU, which means my macbook pro is heating so much, that i have to stopped using it. Even when I am at home connected to power source I prefer not to use it, because of uncomfortable warm keyboard and fan screaming. Not to say outside w/o power source, when my battery lasts 2 hours.
Is there any way to fix it?

There is thread at bugzilla about this problem:
https://bugzilla.mozilla.org/show_bug.cgi?id=930586

Sincerely,
UnicoRush

Masonry/Snap should be renamed to be SnapKit/SnapKit

"Masonry/Snap" is no longer valid, should be replaced with their new name.

github "SnapKit/SnapKit"            >= 0.12.0

Background app refresh

From SuMo:

I have Background App Refresh disabled... system-wide. Yet, the Firefox app managed to get 8.6 hours of Background App Refresh... and a significant chunk of my battery charge. Firefox even used more battery than my Safari app, even though I BARELY used the Firefox app. Firefox is NOT respecting the Background App Refresh setting... it's going ahead and performing Background App Refresh—and tons of it, at that—despite the setting.
This is not just Mozilla's fault, this is Apple's fault as well, because iOS is obviously not enforcing the Background App Refresh setting.
I swiftly deleted Firefox after noticing this. I may give it a second chance in the future, when Apple and Mozilla have gotten a chance to resolve this Background App Refresh issue.

(original post)

I asked the user to provide details about his environment. I'll post it here as soon as it's told.

Can someone confirm it?

Option to move Tabs button to bottom

Can we please get the option to move the Tabs button to the bottom right corner?

Anyone with a 'Plus' iPhone has a very hard time reaching for Tabs, which are essential to most people's browsing.

In my opinion bookmarking isn't important enough to justify placing it in the bottom right corner. Muscle memory from Safari will also serve many people well.

Thank you for your consideration.

boorkmark syncing in v1.1 not working

in the latest app store update it is claimed that bookmark syncing is a newly added feature. am i missing something? i still don't see my desktop bookmarks anywhere in the mobile app.

is this planned for the future? i need to have my desktop bookmarks available on my mobile app, otherwise a 3rd-party browser is pretty tough to use every day.

thanks for the great work up to this point though, i really appreciate it!

Setting button

Move the setting button to main UI.

Link bar is out of the screen

I'm using Firefox on my iPad mini 4 and the link bar gets out off the screen.

I'm using iOS 9.1 and the OS language is Arabic so perhaps the issue because of the RTL layout

Carthage error, bad tag for SnapKit

$ ./update.sh
*** Fetching onepassword-extension
*** Fetching ios_sdk
*** Fetching google-breakpad-ios
*** Fetching XCGLogger
*** Fetching SWXMLHash
*** Fetching SWTableViewCell
*** Fetching SQLite.swift
*** Fetching Snap
*** Fetching SDWebImage
*** Fetching readability
*** Fetching RaptureXML
*** Fetching KIF
*** Fetching GCDWebServer
Failed to check out repository into /Users/gkeeley/Library/Caches/org.carthage.CarthageKit/dependencies/Snap: No object named "Swift-2.0" exists

Swift Compiler Errors - SQLite

Can you advise on how to fix these Swift compiler errors on Xcode 6.2 (Build: 6C131e)?

Followed steps from Building the Code.

Bookmarks not syncing

It appears that bookmarks don't actually seem to sync with your Firefox account.

I have tried:

• Killing the app and starting it again.
• Logging out and back into sync.
• Removing and reinstalling the app.

Syncing works between my various desktop Firefox browsers / computers.

Please push firefox ios into china appstore!

Please push firefox ios into china appstore!

We need it.

Waiting for so long time.

Two feature requests

I hope this is okay to post here. I didn't have a bugzilla account since I wasn't entirely a developer but I just wanted to comment on two minor things that I hope could make it in.

1. In addition to this (https://bugzilla.mozilla.org/show_bug.cgi?id=1109688), could an 'open in private tab' also be added?
2. In addition to this (https://bugzilla.mozilla.org/show_bug.cgi?id=1092561), would it be difficult to support multiple accounts? I.e., say a work Firefox account and a personal one and allow them to be switched (you can sort of do this in Chrome currently, though you have to completely sign out).

How do I build for my physical device? Code signing errors abound!

Can anyone tell me how to build this so I can put it on my phone? I'm a registered developer with a valid signing certificate. However, a number of components of the source here are signed by a variety of other entities. I could not find anything that could help me online. And when I attempt to allow Xcode to fix the issue, it either reports and error or just crashes.

Buildasaur Build Errors

I keep getting fxios-buildasaur saying that my pull requests have build errors. My project builds fine when I run it in Xcode. How can build errors be possible when I haven't changed any project files/settings?

Fix http://git.chromium.org/webm/libwebp.git/info/refs not valid

For people experiencing http://git.chromium.org/webm/libwebp.git/info/refs not valid when performing sh update.sh, modify your Cartfile's SDWebImage repository to the following will fix the issue:

git "https://github.com/joelchen/SDWebImage.git" "master"

Review hard-coded used of GCDWebServer port as a possible startup crasher

I have had this fail once in the simulator trying to use the fixed port. I don't recall the workflow that triggered it. Has no one else seen this during development? I assume this isn't showing up in release builds.
https://github.com/mozilla/firefox-ios/blob/master/Client/Application/WebServer.swift#L22
Consider trying a range of ports before failing.
IMHO seems like an unnecessary risk to rely on the network stack and process system to be bug-free on all iOS variants and properly release that port if the app crashes and is quickly restarted.

Add blocklist support

It would be fantastic if Firefox for iOS could support adding a blocklist such as those used by the popular extension uBlock.

I would see this working as such:

• Option added to settings to paste a URL to a tgz blocklist.
• When a tgz blocklist is added to settings, it is downloaded locally and the hosts / IPs contained within are added to a blocklist similar to a hostsfile on a desktop.

Why is the App icon have white BG? why not transparent like in android?

Add content blocking support

I believe it is possible for third party browsers to take advantage of iOS 9's content blocking capabilities as long as they use they correct Safari webview type. If this is not possible, may I suggest that you natively build in a privacy blocklist such as disconnect, so that users do not have to sacrifice their web privacy when choosing Firefox over Safari on iOS.

Add Upload support

yes really add this for iOS.
See from iCab Mobile
http://www.icab-mobile.de/faq.html

Show by (Why are there issues uploading files?)

Delete

Delete

Consider supporting TextExpander SDK for text expansion

TextExpander offers an SDK that allows text expansion in 3rd party apps from Bluetooth keyboards, etc:
https://smilesoftware.com/textexpander-ios/sdk

Please consider adding support for this to Firefox for iOS.

[Feature] Recently closed tabs

Correct me if I'm missing this, but it doesn't appear to exist in the currently released version